Message-ID: <5522B5E4.1090206@pgmasters.net>
Date: Mon, 06 Apr 2015 12:35:48 -0400
From: David Steele <david@pgmasters.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Sawada Masahiko <sawada.mshk@gmail.com>
CC: Alvaro Herrera <alvherre@2ndquadrant.com>,
 Abhijit Menon-Sen <ams@2ndquadrant.com>,
 Stephen Frost <sfrost@snowman.net>, Fujii Masao <masao.fujii@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Auditing extension for PostgreSQL (Take 2)
References: <54E005CC.1060605@pgmasters.net>
 <20150217153402.GQ6717@tamriel.snowman.net> <54EB4E56.7050102@pgmasters.net>
 <54ECA551.8060306@pgmasters.net> <20150323053146.GA1919@toroid.org>
 <55104204.80008@pgmasters.net>
 <CAD21AoBBQXPBiOncyvZdtOfSzr121GyDoARc4jXo2v-JM_45EQ@mail.gmail.com>
 <20150323181724.GG3636@alvh.no-ip.org>
 <CAD21AoA1-UVvjt0q8wvXBRc83RRwDhBgtRTR5vXByPdKb=e6-g@mail.gmail.com>
 <55118509.8020009@pgmasters.net>
 <CAD21AoD+MFYjjTz08gZtyDNQ77kt71ckyKvo7W+QuPq4icMjQA@mail.gmail.com>
 <55122A1E.7030401@pgmasters.net>
 <CAD21AoBFs2sA31Y+zgioQYfiXc0vGEOM3GcgouNc_AH00QCCow@mail.gmail.com>
 <5512B71C.7030808@pgmasters.net> <551C2F0B.3010305@pgmasters.net>
 <CAD21AoBJQwwFm_S5TitohbHVbb-TWga4=7uOPofgaj+V6hrsmA@mail.gmail.com>
 <551E8F37.2060202@pgmasters.net>
 <CAD21AoDvODLOB4u2u1nMZEXrumyqZqT9A-uefMX=mrAz_CLYuA@mail.gmail.com>
In-Reply-To: 
 <CAD21AoDvODLOB4u2u1nMZEXrumyqZqT9A-uefMX=mrAz_CLYuA@mail.gmail.com>
OpenPGP: id=2624538721DAF9D5FDF4952A9FCDF424A2739CF3
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="kRS21lB9UcDvClnWXB3ggl4uxHU9EWWkL"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--kRS21lB9UcDvClnWXB3ggl4uxHU9EWWkL
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 4/6/15 8:40 AM, Sawada Masahiko wrote:
> On Fri, Apr 3, 2015 at 10:01 PM, David Steele <david@pgmasters.net> wro=
te:
>> On 4/3/15 3:59 AM, Sawada Masahiko wrote:
>>> On Thu, Apr 2, 2015 at 2:46 AM, David Steele <david@pgmasters.net> wr=
ote:
>>>> Let me know if you see any other issues.
>>>>
>>>
>>> I pulled HEAD, and then tried to compile source code after applied
>>> following "deparsing utility command patch" without #0001 and #0002.
>>> (because these two patches are already pushed)
>>> <http://www.postgresql.org/message-id/20150325175954.GL3636@alvh.no-i=
p.org>
>>>
>>> But I could not use new pg_audit patch due to compile error (that
>>> deparsing utility command patch might have).
>>> I think I'm missing something, but I'm not sure.
>>> Could you tell me which patch should I apply before compiling pg_audi=
t?
>>
>> When Alvaro posted his last patch set he recommended applying them to
>> b3196e65:
>>
>> http://www.postgresql.org/message-id/20150325175954.GL3636@alvh.no-ip.=
org
>>
>> Applying the 3/25 deparse patches onto b3196e65 (you'll see one traili=
ng
>> space error) then applying pg_audit-v6.patch works fine.
>>
>=20
> I tested v6 patch, but I got SEGV when I executed test() function I
> mentioned up thread.
> Could you address this problem?

Unfortunately I'm not able to reproduce the issue.  Here's what I tried
based on your original test:

postgres=3D# create table hoge (id int);
CREATE TABLE
postgres=3D# create function test() returns int as $$
postgres$# declare
postgres$#     cur1 cursor for select * from hoge;
postgres$#     tmp int;
postgres$# begin
postgres$#     open cur1;
postgres$#     fetch cur1 into tmp;
postgres$#    return tmp;
postgres$# end$$
postgres-# language plpgsql ;
CREATE FUNCTION
postgres=3D# select test();
 test
------

(1 row)
postgres=3D# insert into hoge values (1);
INSERT 0 1
postgres=3D# select test();
 test
------
    1
(1 row)

And the log output was:

prefix LOG:  statement: create table hoge (id int);
prefix DEBUG:  EventTriggerInvoke 16385
prefix LOG:  AUDIT: SESSION,3,1,DDL,CREATE
TABLE,TABLE,public.hoge,CREATE  TABLE  public.hoge (id pg_catalog.int4
 )  WITH (oids=3DOFF)
prefix LOG:  statement: create function test() returns int as $$
	declare
	    cur1 cursor for select * from hoge;
	    tmp int;
	begin
	    open cur1;
	    fetch cur1 into tmp;
	   return tmp;
	end$$
	language plpgsql ;
prefix DEBUG:  EventTriggerInvoke 16385
prefix LOG:  AUDIT: SESSION,4,1,DDL,CREATE
FUNCTION,FUNCTION,public.test(),"CREATE  FUNCTION public.test() RETURNS
 pg_catalog.int4 LANGUAGE plpgsql  VOLATILE  CALLED ON NULL INPUT
SECURITY INVOKER COST 100   AS '
	declare
	    cur1 cursor for select * from hoge;
	    tmp int;
	begin
	    open cur1;
	    fetch cur1 into tmp;
	   return tmp;
	end'"
prefix LOG:  statement: select test();
prefix LOG:  AUDIT: SESSION,5,1,READ,SELECT,,,select test();
prefix LOG:  AUDIT:
SESSION,5,2,FUNCTION,EXECUTE,FUNCTION,public.test,select test();
prefix LOG:  AUDIT: SESSION,5,3,READ,SELECT,,,select * from hoge
prefix CONTEXT:  PL/pgSQL function test() line 6 at OPEN
prefix LOG:  statement: insert into hoge values (1);
prefix LOG:  AUDIT: SESSION,6,1,WRITE,INSERT,,,insert into hoge values (1=
);
prefix LOG:  statement: select test();
prefix LOG:  AUDIT: SESSION,7,1,READ,SELECT,,,select test();
prefix LOG:  AUDIT:
SESSION,7,2,FUNCTION,EXECUTE,FUNCTION,public.test,select test();
prefix LOG:  AUDIT: SESSION,7,3,READ,SELECT,,,select * from hoge
prefix CONTEXT:  PL/pgSQL function test() line 6 at OPEN

Does the above look like what you did?  Any other information about your
environment would also be helpful.  I'm thinking it might be some kind
of build issue.

--=20
- David Steele
david@pgmasters.net


--kRS21lB9UcDvClnWXB3ggl4uxHU9EWWkL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVIrXkAAoJEIA2uIJQ5SFA6ekP/1sJA39n9RTHxcJld88ZSaf9
Qwr2aAtlCdgVakPV95ch0rfuWc6gszvzZix7d05ElgHWdNTVbHyQL/etUTCsa11E
xWOi64+piJlvh9MRjzOuxRR3bakUMqyKfERc/dSL20ipIruqM371THXnC3uslUNH
GjcZC8KUuaBn3Sw8BNVOSMJugdbHH5e8k1X3iD+xi2rP9Txzni+A1ogE0IHVpciK
m+6NvqDP0PlrNc7C7hwzACAwKqf0OlNybpMa5MdNex2BTzX3BZaIjMqSO1tmL20r
NB0tYfgC67KWobUsr7bvx7tyfl9KTU1iRap4wb2qDQI5JqE9DkBVZuNagJvWPHOY
03kPh90M2oVC+p/xc2uKzzi8GrwJbsHMvO2DxwYQT+rXRxXRAEI0v2Q7Hx+j61ZV
E/PcU/2p/7/1ydT0eKbIPaFelyc2xoYPhQtY0X5S6T7uTbwvmf2w4ipNucFTEBGy
cg1DdFON4pXQ37VLbWchKNX4L8Oq3K4HYN1h7n+ddQ9/q+8tEhdpPHc0zpj8VoA7
2HCkntLCzy1d4fkdVCINSEcxhnhELAjSVxLnn0NqD9uHenisotVw27vSFaL6nv5R
gxFlG7jN2bQs4r+l+iCfmXx0nKCerEznQYaQEVldMs5glUbXs99/eg8b+0HWTnay
N/SudfEEngEBinCNZQ2N
=dADy
-----END PGP SIGNATURE-----

--kRS21lB9UcDvClnWXB3ggl4uxHU9EWWkL--