Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMEAg-0002Yt-B5 for pgsql-hackers@arkaria.postgresql.org; Thu, 02 May 2019 16:02:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hMEAe-0001RZ-LO for pgsql-hackers@arkaria.postgresql.org; Thu, 02 May 2019 16:02:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMEAe-0001Lu-7p for pgsql-hackers@lists.postgresql.org; Thu, 02 May 2019 16:02:52 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMEAb-00081k-Rl for pgsql-hackers@lists.postgresql.org; Thu, 02 May 2019 16:02:51 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x42G2i5U005532; Thu, 2 May 2019 12:02:44 -0400 From: Tom Lane To: Andres Freund cc: Michael Paquier , Postgres hackers Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6 In-reply-to: <20190502155612.ep5wqyninmkrz6uh@alap3.anarazel.de> References: <20190501170603.hx6r3ztyvi3rlgq6@alap3.anarazel.de> <20190501172115.4cvz3rp6np43odut@alap3.anarazel.de> <5483.1556737736@sss.pgh.pa.us> <16043.1556754084@sss.pgh.pa.us> <20190502012520.eyfhhn5ix2ooflys@alap3.anarazel.de> <27459.1556762513@sss.pgh.pa.us> <20190502021913.axyvyyyw5547swy5@alap3.anarazel.de> <25661.1556808540@sss.pgh.pa.us> <20190502153107.o5zadep4ehebzoqy@alap3.anarazel.de> <4870.1556811688@sss.pgh.pa.us> <20190502155612.ep5wqyninmkrz6uh@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 02 May 2019 08:56:12 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5530.1556812964.1@sss.pgh.pa.us> Date: Thu, 02 May 2019 12:02:44 -0400 Message-ID: <5531.1556812964@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > On 2019-05-02 11:41:28 -0400, Tom Lane wrote: >> But don't we need to worry about resetting relfrozenxid? > Indexes don't have that though? We couldn't do it for pg_class itself, > but that's not a problem here. Hmm. Again, that seems like the sort of assumption that could bite us later. But maybe we could add some assertions that the new values match the old? I'll experiment. regards, tom lane