Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YlNZf-0005vp-9F for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2015 20:18:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YlNZd-0005I3-LE for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2015 20:18:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YlNZV-00055W-9K for pgsql-hackers@postgresql.org; Thu, 23 Apr 2015 20:18:05 +0000 Received: from mail-bn1on0098.outbound.protection.outlook.com ([157.56.110.98] helo=na01-bn1-obe.outbound.protection.outlook.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1YlNZS-0002gH-C2 for pgsql-hackers@postgresql.org; Thu, 23 Apr 2015 20:18:03 +0000 Authentication-Results: postgresql.org; dkim=none (message not signed) header.d=none; Received: from decina.local (70.113.16.71) by CY1PR11MB0684.namprd11.prod.outlook.com (25.163.236.22) with Microsoft SMTP Server (TLS) id 15.1.136.25; Thu, 23 Apr 2015 20:17:59 +0000 Message-ID: <55395373.9030006@BlueTreble.com> Date: Thu, 23 Apr 2015 15:17:55 -0500 From: Jim Nasby User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andres Freund , Bruce Momjian , Josh Berkus CC: Stephen Frost , Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: tablespaces inside $PGDATA considered harmful References: <20150130171920.GJ3854@tamriel.snowman.net> <54CBD519.8030502@agliodbs.com> <54CBF6FE.8030209@agliodbs.com> <20150423024102.GJ13362@momjian.us> <55390BC5.3000204@BlueTreble.com> <36B008EF-B438-45BD-A645-C242F81F609D@anarazel.de> In-Reply-To: <36B008EF-B438-45BD-A645-C242F81F609D@anarazel.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [70.113.16.71] X-ClientProxiedBy: BY1PR0501CA0016.namprd05.prod.outlook.com (25.162.139.26) To CY1PR11MB0684.namprd11.prod.outlook.com (25.163.236.22) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR11MB0684; X-Forefront-Antispam-Report: BMV:1; SFV:NSPM; SFS:(10009020)(6009001)(377454003)(479174004)(51704005)(24454002)(23676002)(86362001)(93886004)(65956001)(42186005)(65806001)(47776003)(83506001)(46102003)(19580405001)(19580395003)(2950100001)(50466002)(87976001)(122386002)(15975445007)(65816999)(87266999)(54356999)(76176999)(50986999)(66066001)(4001350100001)(92566002)(64126003)(99136001)(77156002)(62966003)(117636001)(40100003)(5001770100001)(36756003)(85282002)(62816006)(336755003)(18886065003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR11MB0684; H:decina.local; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5002010)(5005006); SRVR:CY1PR11MB0684; BCL:0; PCL:0; RULEID:; SRVR:CY1PR11MB0684; X-Forefront-PRVS: 0555EC8317 X-OriginatorOrg: bluetreble.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2015 20:17:59.2620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR11MB0684 X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 4/23/15 11:01 AM, Andres Freund wrote: > On April 23, 2015 6:12:05 PM GMT+03:00, Jim Nasby wrote: >> On 4/22/15 9:41 PM, Bruce Momjian wrote: >>> The case this doesn't catch is referencing a >>> symbolic link that points to the same directory. We can't make it an >>> error so people can use pg_upgrade these setups. >> >> Couldn't we make it an ERROR unless IsBinaryUpgrade? > > People still upgrade without pg upgrade. Yes, but only after creating a brand new cluster from scratch, which would then disallow them from putting tablespaces in $PGDATA. Or are you saying people do binary upgrades without pg_upgrade? I don't think we have any obligation to support that... -- Jim Nasby, Data Architect, Blue Treble Consulting Data in Trouble? Get it in Treble! http://BlueTreble.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers