Message-ID: <553d2348-1015-3546-2be8-b5a8a745dfa8@pgmasters.net>
Date: Thu, 2 Dec 2021 12:38:50 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Content-Language: en-US
To: Andrew Dunstan <andrew@dunslane.net>,
 "Bossart, Nathan" <bossartn@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
 Michael Paquier <michael@paquier.xyz>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
References: 
 <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
 <YZ7Amotspa4ve+91@paquier.xyz>
 <CAHg+QDekOasWArvmPeOqhyTUHR40DsDOWyt7OaKxpQ7eFYqysw@mail.gmail.com>
 <YaB3Oj4GfPOZ/3LC@paquier.xyz> <417711.1637940660@sss.pgh.pa.us>
 <20211130142042.GR26257@tamriel.snowman.net>
 <3404870c1a921bafbcd168c098088981fe082ab1.camel@cybertec.at>
 <CAOuzzgoYqzH+c_fzapjGFh6kiZjXDc0jPCQctbQjajn7a4vyxA@mail.gmail.com>
 <845544A4-0B0E-41D2-903C-C8B9E8A18812@amazon.com>
 <1661037.1638311167@sss.pgh.pa.us>
 <1cce9981-2c48-981a-a936-812830dfb3b1@pgmasters.net>
 <BC31E8F0-7CFF-462E-9B27-727AD573A675@amazon.com>
 <9427c6b3-5e0b-e27f-a2e7-ec1ebc00b582@pgmasters.net>
 <AC0ADAC3-E196-42A0-9471-A22F966E1A5F@amazon.com>
 <E87F96A8-9DBD-4E8D-8EE9-A03B4F126119@amazon.com>
 <4a363c5a-473f-9cb9-9f59-74a230575340@dunslane.net>
From: David Steele <david@pgmasters.net>
In-Reply-To: <4a363c5a-473f-9cb9-9f59-74a230575340@dunslane.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/553d2348-1015-3546-2be8-b5a8a745dfa8%40pgmasters.net>
Precedence: bulk

On 12/2/21 11:00, Andrew Dunstan wrote:
> 
> On 12/1/21 19:30, Bossart, Nathan wrote:
>> On 12/1/21, 10:37 AM, "Bossart, Nathan" <bossartn@amazon.com> wrote:
>>> On 12/1/21, 8:27 AM, "David Steele" <david@pgmasters.net> wrote:
>>>> On 11/30/21 18:31, Bossart, Nathan wrote:
>>>>> Do you think it's still worth trying to make it safe, or do you think
>>>>> we should just remove exclusive mode completely?
>>>> My preference would be to remove it completely, but I haven't gotten a
>>>> lot of traction so far.
>>> In this thread, I count 6 people who seem alright with removing it,
>>> and 2 who might be opposed, although I don't think anyone has
>>> explicitly stated they are against it.
>> I hastily rebased the patch from 2018 and got it building and passing
>> the tests.  I'm sure it will need additional changes, but I'll wait
>> for more feedback before I expend too much more effort on this.
>>
> 
> Should we really be getting rid of
> PostgreSQL::Test::Cluster::backup_fs_hot() ?

Agreed, it would be better to update backup_fs_hot() to use exclusive 
mode and save out backup_label instead.

Regards,
-David