Message-ID: <5543706E.8020207@pgmasters.net>
Date: Fri, 01 May 2015 08:24:14 -0400
From: David Steele <david@pgmasters.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Sawada Masahiko <sawada.mshk@gmail.com>
CC: Fujii Masao <masao.fujii@gmail.com>, Simon Riggs <simon@2ndquadrant.com>,
 Tatsuo Ishii <ishii@postgresql.org>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Abhijit Menon-Sen <ams@2ndquadrant.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: Auditing extension for PostgreSQL (Take 2)
References: <552326EE.4060509@pgmasters.net>
 <CA+U5nMJkT0ZR3ZD-NhqX=OAfpMJak2ORUE4q=3+zFHay6yuTNw@mail.gmail.com>
 <552D2C1A.3060002@pgmasters.net>
 <20150415.081354.1167351714960358354.t-ishii@sraoss.co.jp>
 <552DA959.2010102@pgmasters.net>
 <CAD21AoDUG8G90SUo70JL=AKDA4dXGNb_wAc4-MvxtwvuMRO0kA@mail.gmail.com>
 <CAD21AoCdr6R7T-PuAQf7S70c6qqX1JvBV55idbfcPtz_tEZ5hQ@mail.gmail.com>
 <552EA121.1090603@pgmasters.net>
 <CAD21AoBoS6Q5yjB05LpfKTzhKmarqwwVq06fuPDFsm0T8gSk_Q@mail.gmail.com>
 <5534FC6E.9030906@pgmasters.net>
 <CAD21AoCxFOLWk-k179PyFxzwjkOW8oPaNk73GxZi+Yw2+n4YFA@mail.gmail.com>
 <553938A1.7030707@pgmasters.net>
 <CAD21AoDBt44ABM_0WMketM8bZtqLBMrJpd9RD5tE=Dkr57ft_A@mail.gmail.com>
 <553FA477.5010803@pgmasters.net>
 <CAD21AoCQSGZ5x+sfs4g1x_8Fip60x8ULQFTAGB5XTrKQZvPWPA@mail.gmail.com>
 <CAHGQGwGJnRW69rSL1=tza571_eA44hBeChg-NAVrqQytESgvLg@mail.gmail.com>
 <55429DA5.40503@pgmasters.net>
 <CAD21AoCRhxrXuFOGLMHNuyfzTCqwHPSKrZWwsw+M8cv_CawFag@mail.gmail.com>
In-Reply-To: 
 <CAD21AoCRhxrXuFOGLMHNuyfzTCqwHPSKrZWwsw+M8cv_CawFag@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="1836EOPnGKtRpFIb6xIaUTrvOaLOj81IA"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1836EOPnGKtRpFIb6xIaUTrvOaLOj81IA
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 5/1/15 5:58 AM, Sawada Masahiko wrote:
> On Fri, May 1, 2015 at 6:24 AM, David Steele <david@pgmasters.net> wrot=
e:
>>
>> May 15th is the feature freeze, so that does give a little time.  It's=

>> not clear to me what a "self-contained" part of the patch would be.  I=
f
>> you have specific ideas on what could be broken out I'm interested to
>> hear them.
>>
>> Patch v11 is attached with the changes discussed here plus some other
>> improvements to the documentation suggested by Erik.
>>
>=20
> For now, since pg_audit patch has a pg_audit_ddl_command_end()
> function which uses part of un-committed "deparsing utility commands"
> patch API,
> pg_audit patch is completely depend on that patch.
> If API name, interface are changed, it would affect for pg_audit patch.=

> I'm not sure about progress of "deparsing utility command" patch but
> you have any idea if that patch is not committed into 9.5 until May
> 15?

Currently the deparse dependent code is ifdef'd so pg_audit compiles and
operates just fine against master.  Having the deparse code is nice
because it allows less common object types to log with full-qualified
names but it is in not a requirement for pg_audit.

I'd like to see at least patch 0001 of deparse committed.  Not only
because it provides the functionality that deparse uses, but because it
makes event triggers truly useful in pl/pgsql.

--=20
- David Steele
david@pgmasters.net


--1836EOPnGKtRpFIb6xIaUTrvOaLOj81IA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVQ3BvAAoJEIA2uIJQ5SFA7NYQAISWwHLj6DEkPbKLNNtwAK1H
4Z7mKPp9DTsuLOZX9AvSsORt9oywE5hYZHEhJ1NuoOcvOax9X5VVxX1VDzukyHLX
mwBvWmfzZd1Xc5czCYZpyBAAowkr66UcO8h4uJc33AbyNvZVrY4/wtWs5EY/9BlI
bBTJr6/phj0p3nj1QavEVRi5WipbNSiXIx4wELNo3tjJczJVeaL8zQCPrRyYr7D9
dnpA+HZ2apzOVJdQ/iq0OlLtI7DDhsxIWy9Be+fL2/jTObHkQiy6+a62dAmA6Ux1
kdTd2/6/FefULjINyWWPK0HVMX9Y+OtUhDWEci+P9xHCCEag/c4anm+rfmuM7MkB
dSmTS4tp9KLKEYtarp4EWQSb3ix1K9d9IgYNV+qsRz3x2CVzCYnb3DlDbqOIL1f4
lqJlwWgwJJb0ycVTiqZQ/u+7aRGCHY/XXzXdk6JFNGgLHrx1azpgeaGs1lqF3WP/
XrOA4HpeWaQ8X5Xy5ZS4We3hA4VvVofjj+2fAcUYbFu2E2zvTtra89mbyPvF0LnO
VGrE/WSOJweIG/SLwVcxjczviqZbf80QEMoDMDeprMecP83YtGH1WZu8VKWiDpjG
wp9miaSjDaAXRdiTw1FgtdWyGUgMNTxDMRU3teTAweNagrO+KnYv+3ICHX3OSwPi
Ht1yHSyBxA09HV+ezqtC
=J3pl
-----END PGP SIGNATURE-----

--1836EOPnGKtRpFIb6xIaUTrvOaLOj81IA--