Message-ID: <5547DB0A.2020904@gmx.net>
Date: Mon, 04 May 2015 16:48:10 -0400
From: Peter Eisentraut <peter_e@gmx.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Andres Freund <andres@anarazel.de>, Greg Stark <stark@mit.edu>
CC: Haribabu Kommi <kommi.haribabu@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 Abhijit Menon-Sen <ams@2ndquadrant.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Providing catalog view to pg_hba.conf file - Patch
 submission
References: 
 <CAM-w4HM_s77AdoXq3Xdu7sYOd-SpRr8E6Em_tuV4hH5=4E14tQ@mail.gmail.com>
 <CAJrrPGd3O2SX29hpwr+zW3TiH3djwX+Um=LwWpup27FgPXfr9A@mail.gmail.com>
 <CAM-w4HN=6oNdeUT8NnEmxYcySnnxjjfke2bb12az4110Ysea3A@mail.gmail.com>
 <CAJrrPGdXK3d6qYe7f8CkjK=3ckV++e8=dW2k4HsCgpz6-vNa0g@mail.gmail.com>
 <CAJrrPGfin+RCa_CT_pBMa4u31Aa7kcUOggQ4F1sMX3m5EUV-tA@mail.gmail.com>
 <55024C6C.6000207@gmx.net>
 <CAJrrPGe5Du0wmELzhWF0N-iiy6j5N0WNrhOhPuT5o5-bSCP6gA@mail.gmail.com>
 <CAFj8pRCYdtmceCxEtjSm9RjMiDSqVhC1QQdYSW3Fh6MQmYRgeA@mail.gmail.com>
 <CAJrrPGect-xLu+cmq9RN1EeGXvMeMJAtjWNxasKdyUjJKt0ksQ@mail.gmail.com>
 <CAM-w4HNDCbw6SBGutH2T9fRtYe-Wr1XPGAr3w_esav69LKXMMg@mail.gmail.com>
 <20150501163358.GE16366@awork2.anarazel.de>
In-Reply-To: <20150501163358.GE16366@awork2.anarazel.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 5/1/15 12:33 PM, Andres Freund wrote:
> On 2015-04-08 19:19:29 +0100, Greg Stark wrote:
>> I'm not sure what the best way to handle the hand-off from patch
>> contribution to reviewer/committer. If I start tweaking things then
>> you send in a new version it's actually more work to resolve the
>> conflicts. I think at this point it's easiest if I just take it from
>> here.
> 
> Are you intending to commit this?

It still looks quite dubious to me.

The more I test this, the more fond I grow of the idea of having this
information available in SQL.  But I'm also growing more perplexed by
how this the file is mapped to a table.  It just isn't a good match.

For instance: What is keyword_databases?  Why is it an array?  Same for
keyword_users.  How can I know whether a given database or user matches
a keyword?  What is compare_method?  (Should perhaps be
keyword_address?)  Why is compare method set to "mask" when a hostname
is set?  (Column order is also a bit confusing here.)  I'd also like
options to be jsonb instead of a text array.

Ultimately, I don't see how this is better than just showing the raw
file.  I don't see a sensible way to compute answers to questions such
as "What is the authentication method for user X from IP address Y."  If
I can't do that, what's the point of having a processed version?


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers