From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vik Fearing <vik.fearing@2ndquadrant.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Andreas Karlsson <andreas@proxel.se>,
        Andres Freund <andres@anarazel.de>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        Andrew Gierth <andrew@tao11.riddles.org.uk>,
        David Fetter <david@fetter.org>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Early WIP/PoC for inlining CTEs
In-reply-to: <3b979d47-e98d-f3c6-f260-a88f3c470fe5@2ndquadrant.com>
References: <dccb37dd-2f52-dbd7-a4c4-72a5853f4838@proxel.se>
 <d4daf011-01cf-6bf9-3f15-85ae1572e909@proxel.se>
 <87r2dxrw1z.fsf@news-spur.riddles.org.uk>
 <d0619160-10af-dcc9-4e7d-57845b92570c@proxel.se>
 <CAEepm=2x3kJ5AdkKmEf_ODAZm7+e=7DW1u-+ZwfncWvd8xDaiA@mail.gmail.com>
 <CA+Tgmob=Dpje+oGCYgJCoUok=iPQarGjPqRLYS1qKzChkFfKcA@mail.gmail.com>
 <20190111181934.g5qig23o7rxubnjt@alap3.anarazel.de>
 <CAEepm=2n8hChj548H0R5g5JAx3cokpZwTqRzYhN2oVGqBONwOA@mail.gmail.com>
 <20190111190403.77ye7m5mxypxsf4l@alap3.anarazel.de>
 <CA+TgmobVMPX1wJxPaRQ=FZBzp-AQ=JWK=bzxztqwj=MsOsrnrA@mail.gmail.com>
 <00818be9-2f63-f584-efcd-d97ee0662905@proxel.se>
 <CA+TgmoapASa3RQi=DuSikPoPF4363czSD8KxbOxsfW5XmO3WpQ@mail.gmail.com>
 <5715d93e-6ebc-be17-c2c3-56a873100a38@proxel.se>
 <29576.1548084476@sss.pgh.pa.us>
 <CA+TgmoYZYj8eLdV9AcROtmPW4AJA7ANh3xQh7BcafaPfCnmv+g@mail.gmail.com>
 <12408.1548707732@sss.pgh.pa.us> <c16909ed-0789-5199-f315-!
 5433d83a0026@2ndquadrant.com> <32184.1548713132@sss.pgh.pa.us>
 <3b979d47-e98d-f!
 3c6-f260-a88f3c470fe5@2ndquadrant.com>
Comments: In-reply-to Vik Fearing <vik.fearing@2ndquadrant.com>
	message dated "Sun, 03 Feb 2019 12:16:59 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5555.1549208397.1@sss.pgh.pa.us>
Date: Sun, 03 Feb 2019 10:39:57 -0500
Message-ID: <5556.1549208397@sss.pgh.pa.us>
Precedence: bulk

Vik Fearing <vik.fearing@2ndquadrant.com> writes:
> On 28/01/2019 23:05, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>>> Or put it at the end?
>>> WITH ctename AS ( query ) MATERIALIZED

>> Yeah, I thought about that too, but it doesn't seem like an improvement.
>> If the query is very long (which isn't unlikely) I think people would
>> prefer to see the option(s) up front.

> On the other hand, the end is where the other options go (that we
> haven't implemented yet).  See <search or cycle clause>.

Yeah, I noticed that too while working on the latest patch revision.
ISTM that's actually an argument for *not* putting PG-specific
syntax there.  We'd increase the risk of conflicting with future spec
additions, assuming that they continue to add stuff at the end rather
than just after AS.

			regards, tom lane