Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YuFeR-0006TY-Af for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2015 07:39:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YuFeQ-0003dD-Rx for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2015 07:39:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YuFeP-0003d7-Oi for pgsql-hackers@postgresql.org; Mon, 18 May 2015 07:39:49 +0000 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1YuFeN-0008DV-73 for pgsql-hackers@postgresql.org; Mon, 18 May 2015 07:39:48 +0000 Received: by wizk4 with SMTP id k4so67600646wiz.1 for ; Mon, 18 May 2015 00:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=FnT/Ly2Aq8wxeY52LRH4jAzTjvQPbBRRdtlQw6CKZOA=; b=d1qoMwswBSlIPKKHtvV0WaVdQfdkVPTjWkSU8R0DZu7ZGs7RWQi257YscTMvN8pE2w p5YPGFLyIGjzkxA4xyNqqeeQy95jcKoFDjD/6DC/he210UxFUMaThy+92JuBck5gpAqU at6rA5DYBOjnFULWtFXH+5kf4TO3k246lubgsuEtwGXbqzxz0ynJhNX80elZGVYp5clr VYU5GdxdeixAluNOb5BKBI+ftWCmkbnA0M52bzCo3Rz0Ut5iXuBkMSrLIlOq5T8ITNw+ ecNUgG58Gf8PRYWIWKftGby1OONbE6hV5SzvzoyXHpngQw2juD/89an38Q/Bpg+yatVe G9tg== X-Received: by 10.180.85.42 with SMTP id e10mr19211564wiz.17.1431934785813; Mon, 18 May 2015 00:39:45 -0700 (PDT) Received: from [192.168.1.99] (dsl-hkibrasgw1-58c38f-82.dhcp.inet.fi. [88.195.143.82]) by mx.google.com with ESMTPSA id 9sm15510703wjr.11.2015.05.18.00.39.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2015 00:39:45 -0700 (PDT) Message-ID: <5559973F.3070008@iki.fi> Date: Mon, 18 May 2015 10:39:43 +0300 From: Heikki Linnakangas Reply-To: hlinnaka@iki.fi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Jim Nasby , Alexander Korotkov CC: Tomas Vondra , pgsql-hackers Subject: Re: KNN-GiST with recheck References: <20140926011800.GA8130@momjian.us> <20140929021631.GG12447@momjian.us> <20141006093609.GA12899@hasegeli.com> <5490357C.8090800@vmware.com> <54EC8D3E.2000908@2ndquadrant.com> <5553A2FF.1030501@iki.fi> <55552F9D.4090603@iki.fi> <55552FFD.8030808@iki.fi> <5556682C.5010900@BlueTreble.com> In-Reply-To: <5556682C.5010900@BlueTreble.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/16/2015 12:42 AM, Jim Nasby wrote: > On 5/14/15 6:30 PM, Heikki Linnakangas wrote: >> On 05/15/2015 02:28 AM, Heikki Linnakangas wrote: >>> I think this is now ready for committing, but I'm pretty tired now so >>> I'll read through this one more time in the morning, so that I won't >>> wake up to a red buildfarm. > > If anyone feels motivated to fix, there's a typo in the comment for > IndexNextWithReorder (s/his/this/): > + * Like IndexNext, but his version can also re-check any Fixed, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers