From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Smith <smithpb2250@gmail.com>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
In-reply-to: <CAHut+PvfaUZQR3rEnj-Dcg_6713Wu4yRdd-yZkkC9NVsARht8A@mail.gmail.com>
References: <CAHut+PvfaUZQR3rEnj-Dcg_6713Wu4yRdd-yZkkC9NVsARht8A@mail.gmail.com>
Comments: In-reply-to Peter Smith <smithpb2250@gmail.com>
	message dated "Thu, 12 Dec 2024 12:27:54 +1100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <556791.1733967676.1@sss.pgh.pa.us>
Date: Wed, 11 Dec 2024 20:41:16 -0500
Message-ID: <556792.1733967676@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/556792.1733967676%40sss.pgh.pa.us>
Precedence: bulk

Peter Smith <smithpb2250@gmail.com> writes:
> While reviewing a patch for another pg_createsubscriber thread I found
> that multiple TAP tests have a terrible wrapping where the command
> options and their associated oparg are separated on different lines
> instead of paired together nicely. This makes it unnecessarily
> difficult to see what the test is doing.

I think that is mostly the fault of pgperltidy.  We did change
the options we use with it awhile back, so maybe now it will honor
your manual changes to its line-wrapping choices.  But I wouldn't
bet on that.  Did you check what happens if you run the modified
code through pgperltidy?

(If the answer is bad, we could look into making further changes so
that pgperltidy won't override these decisions.  But there's no point
in manually patching this if it'll just get undone.)

			regards, tom lane