Message-ID: <556CBFEC.6010704@gmx.net>
Date: Mon, 01 Jun 2015 16:26:20 -0400
From: Peter Eisentraut <peter_e@gmx.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>, Josh Berkus <josh@agliodbs.com>
CC: Peter Geoghegan <pg@heroku.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: RFC: Remove contrib entirely
References: <55674016.80005@commandprompt.com>
 <CAFj8pRC=sccsmdTTVT0XW316-HACK0Fkh8PYAOwVaGSANV80AA@mail.gmail.com>
 <CAECtzeUk_e=uCrwJSz-Z5MbiaqwuFf2gCs9iVkV8LTMesXAZ7Q@mail.gmail.com>
 <CAB7nPqREqu33nQZOnqP-U4F_b643vNZLa24YQ7G8DtEiJ=6U_g@mail.gmail.com>
 <CAFj8pRCAZDQs_ObBb46yfxS-t4rmnC-ujYD2nTCx7jRb2GENGA@mail.gmail.com>
 <WM!cba09fcb04a200dca6aa50578870e5360aceff298c70e35b89e1c83bb825513e3e16610e8589312b97b9deb3c9c52b72!@asav-1.01.com>
 <5568B43E.5030003@agliodbs.com>
 <CAM3SWZR_5+BZ0bfYas0aFqzKtMOzwgeVxLFcoADdzVHk8C_YgA@mail.gmail.com>
 <WM!55dc4215d3d71da9dd4a8bb3007479f41afcd00bae64bf4ffb96f86b4a135d0f1609c2953c807533ab1bef7ce257301b!@asav-2.01.com>
 <5568D5A4.3020002@agliodbs.com> <4946.1432935300@sss.pgh.pa.us>
In-Reply-To: <4946.1432935300@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 5/29/15 5:35 PM, Tom Lane wrote:
> But let's get to the point: the real reason for keeping most of these
> contrib modules in the core distribution is that they are essential test
> cases for core's extensibility features.  contrib/isn is actually a good
> example of that.  It made us realize that extensions that create types
> that are physically equivalent to int8 or float8 were broken when we made
> those types potentially pass-by-value; we had to add a CREATE TYPE option
> to allow that to still work (cf commit 3f936aacc057e4b3).  If contrib/isn
> had not been around and been getting built by the buildfarm, we would have
> found that out only much later and with much more pain.

But the generalization of that argument is that we need to keep around
all possible code forever because it might teach us something in the future.

But it is a valid point that we'd need to build up more extension API
tests before we start cutting back significantly on the
maybe-example-maybe-real extensions that we ship in contrib.  We need to
find a good middle ground.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers