Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xB4Sh-00000002zEO-3ndi for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Sep 2026 06:03:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xB4Sf-000000080Tb-3TXa for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Sep 2026 06:03:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xB4Sf-000000080TS-215z for pgsql-hackers@lists.postgresql.org; Mon, 28 Sep 2026 06:03:37 +0000 Received: from iguana.tulip.relay.mailchannels.net ([23.83.218.253]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xB4Sd-00000001gdQ-0U6D for pgsql-hackers@postgresql.org; Mon, 28 Sep 2026 06:03:37 +0000 X-Sender-Id: hostingeremail|x-authuser|david@pgbackrest.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8B0304C198B; Mon, 28 Sep 2026 06:03:31 +0000 (UTC) Received: from fr-int-smtpout12.hostinger.io (trex-green-7.trex.outbound.svc.cluster.local [100.96.12.141]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id 548154C1B10; Mon, 28 Sep 2026 06:03:29 +0000 (UTC) X-Sender-Id: hostingeremail|x-authuser|david@pgbackrest.org X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|david@pgbackrest.org X-MailChannels-Auth-Id: hostingeremail X-Reaction-Company: 2180a4e6511d708a_1790575411366_3270998226 X-MC-Loop-Signature: 1790575411366:1078349121 X-MC-Ingress-Time: 1790575411366 Received: from fr-int-smtpout12.hostinger.io (fr-int-smtpout12.hostinger.io [148.222.54.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.96.12.141 (trex/8.0.2); Mon, 28 Sep 2026 06:03:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgbackrest.org; s=hostingermail1; t=1790575407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5zQ4sfG+10YUQkrIQDt4WOzdTLmwBaHHNRBibgbeMCE=; b=Xch9lj3ykjXplJhy794gT5/qBUq+6rf1Q34y9joQfcrEOMYO3+/A8/G9v5P+IUCCpq7UNl Gh0q1vTUd7nvMY+O2/9ug1fa9MxpDiOoogZxhyJihMbgpsZvBh1GP5BRbxbgEtETkbu9dD qw/6JOvxm8h9HOM3uUhFdPrX7JQUEPD+oyU+7Ie+nFMfO60DHPxSC5DynZtUO7H1uc+LhP E9A4OUCQldFzPI9VHEmwj8VdxDd5SNboYu/ngBsnVyA9S9ZVFXUs7fmk3ATK7CF5xFDBW/ /IfJY3dSfr/4LrjixKxE8pB7zaWJJreETkyzqCh3nceFLp2kszq7kl8yec+HmQ== Received: from [10.3.0.2] (unknown [187.14.50.164]) (Authenticated sender: david@pgbackrest.org) by smtp.hostinger.com (smtp.hostinger.com) with ESMTPSA id 4htW2K53J4z1y5S; Mon, 28 Sep 2026 06:03:21 +0000 (UTC) Message-ID: <556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org> MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Return pg_control from pg_backup_stop(). To: shihao zhong Cc: Andrey Borodin , Andy Pogrebnoi , Michael Paquier , Haibo Yan , Pg Hackers , Heikki Linnakangas , Robert Haas , Andres Freund , Fujii Masao , Shaun Thomas References: <8b8aa673-fcef-4e14-a05d-0885283ef1b8@pgbackrest.org> <1800c83c-264a-4183-9da5-ac78e25849a8@pgbackrest.org> <3b23e3b7-53d2-4784-b482-05cca3327acb@pgbackrest.org> <4771ba04-ca9d-4bd0-be09-14bbb9243e33@pgbackrest.org> Content-Language: en-US From: David Steele In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 28 Sep 2026 06:03:21 +0000 (UTC) X-CM-Analysis: v=2.4 cv=V5Av0vni c=1 sm=1 tr=0 ts=6aba032f a=EpFRTcYYruYqU1OC0IklVA==:117 a=EpFRTcYYruYqU1OC0IklVA==:17 a=IkcTkHD0fZMA:10 a=v3b2fBw2oonK6-O1aBkA:9 a=QEXdDO2ut3YA:10 X-CM-Envelope: MS4xfDZxkp0g6+E5HU/5PWtdDZwzGmzoYHGy5Q9+d9UfPPQeSd/4SWzkxkOTqscBrDlHFZKnzYbWdbLIYsa5EYR2HHCGEUNsvuBa2dZnyVoLca151ocfzlRL xEY1uoPg5MzC6HFKb2jN+X4mFO0Ir0LS6EBcRBKKuLdKevQ9eBP8gkKdnDFYs4JotV06Vvh0MvjemfjefzKlVz5sCI6IcW3tprlQr8+M6KHs7MAcwFMxDEle 0nHrDDjl62WSV/SYZ3M3Jkkoe2MrDHrWyyZ6Phbe8DZrYIG2j5E8PM8TklFwio2QTlCnb2ZZkvZi+WC1nu/IFdoRTx2dmKLMBtlz4FbCnzTlP9bR7Sg8vYcK kARdkkVInjFlZTWaijd2wyUii5y9Fs8SbcVbanQpQOwwXCO9/37qYTdta0vxGxQB3ZXITfAR7uRA0FLCHODCTVesSfv7sFTfvzKE0hL1SspzX4pwr9TtiwrH anBwS5f9gvRRzAOLrdD6fWo4+2H0SqpO8LnlF5/j2epvUnSWPvfLI/TaDqU= X-AuthUser: david@pgbackrest.org List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Shihao, On 9/27/26 19:13, shihao zhong wrote: > > On the pg_resetwal patch, one question before I write it. A restored backup > is never cleanly shut down, so pg_resetwal already needs -f there. A > backup_label check that -f overrides would only change the message. I'd > rather refuse even with -f, like the postmaster.pid check, and make the user > remove backup_label by hand. 058 would then need to remove backup_label > before its pg_resetwal step. I would definitely prefer to force the user to remove backup_label before pg_resetwal will continue (even with -f). The presence of backup_label indicates they are making a mistake by using pg_resetwal, when they should probably be configuring recovery instead. Regards, -David