Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYk8y-0002Kb-K8 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 07:18:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYk8x-000789-J1 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 07:18:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYk8x-000781-Az for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 07:18:11 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYk8u-0003XT-Fa for pgsql-hackers@postgresql.org; Fri, 08 Oct 2021 07:18:11 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 5486D6009A for ; Fri, 8 Oct 2021 16:18:02 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.3 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_97fac82966e575f7a70c1d97eef7e8c3" Content-Transfer-Encoding: 7bit Date: Fri, 08 Oct 2021 16:18:02 +0900 From: bt21masumurak To: pgsql-hackers Subject: Improve the HINT message of the ALTER command for postgres_fdw User-Agent: Roundcube Webmail/1.4.11 Message-ID: <557d06cebe19081bfcc83ee2affc98d3@oss.nttdata.com> X-Sender: bt21masumurak@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_97fac82966e575f7a70c1d97eef7e8c3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi When 'ALTER FOREIGN DATA WRAPPER OPTIONS' is executed against postgres_fdw, the HINT message is printed as shown below, even though there are no valid options in this context. =# ALTER FOREIGN DATA WRAPPER postgres_fdw OPTIONS (format 'csv'); ERROR: invalid option "format" HINT: Valid options in this context are: I made a patch for this problem. regards, Kosei Masumura --=_97fac82966e575f7a70c1d97eef7e8c3 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=diff.patch Content-Disposition: attachment; filename=diff.patch; size=740 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcG9zdGdyZXNfZmR3L29wdGlvbi5jIGIvY29udHJpYi9wb3N0 Z3Jlc19mZHcvb3B0aW9uLmMKaW5kZXggNWJiMWFmNDA4NC4uMTllZGY5ODM2MCAxMDA2NDQKLS0t IGEvY29udHJpYi9wb3N0Z3Jlc19mZHcvb3B0aW9uLmMKKysrIGIvY29udHJpYi9wb3N0Z3Jlc19m ZHcvb3B0aW9uLmMKQEAgLTEwNyw4ICsxMDcsMTAgQEAgcG9zdGdyZXNfZmR3X3ZhbGlkYXRvcihQ R19GVU5DVElPTl9BUkdTKQogCQkJZXJlcG9ydChFUlJPUiwKIAkJCQkJKGVycmNvZGUoRVJSQ09E RV9GRFdfSU5WQUxJRF9PUFRJT05fTkFNRSksCiAJCQkJCSBlcnJtc2coImludmFsaWQgb3B0aW9u IFwiJXNcIiIsIGRlZi0+ZGVmbmFtZSksCi0JCQkJCSBlcnJoaW50KCJWYWxpZCBvcHRpb25zIGlu IHRoaXMgY29udGV4dCBhcmU6ICVzIiwKLQkJCQkJCQkgYnVmLmRhdGEpKSk7CisJCQkJCSBidWYu bGVuID4gMAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/IGVycmhp bnQoIlZhbGlkIG9wdGlvbnMgaW4gdGhpcyBjb250ZXh0IGFyZTogJXMiLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVmLmRhdGEpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogZXJyaGludCgiVGhlcmUg YXJlIG5vIHZhbGlkIG9wdGlvbnMgaW4gdGhpcyBjb250ZXh0LiIpKSk7CiAJCX0KIAogCQkvKgo= --=_97fac82966e575f7a70c1d97eef7e8c3--