Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gozOJ-0000mv-A5 for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 23:35:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gozOF-0004vM-OH for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 23:35:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gozOF-0004vD-BD for pgsql-hackers@lists.postgresql.org; Wed, 30 Jan 2019 23:35:31 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gozOC-0005a7-HY for pgsql-hackers@postgresql.org; Wed, 30 Jan 2019 23:35:30 +0000 Received: by mail-it1-x142.google.com with SMTP id z7so1127295iti.0 for ; Wed, 30 Jan 2019 15:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lvtAxxkT5ADxtwuXzIeH0UltaEOLDURpLXOOrqJ/x9U=; b=s5xMKGZxSjSYUu8x1Z84X7fquRZdhZXImzhebhXkO6PnMgCk0bsO6jLcIAHY1jCIrD Ej0wnoQHKZV5LFxUESo+c1NWkC/rLlK17fqM+i0DWZs6XkbEjcN9DrUBDwOZfk56uqH4 DZtgE0dcrbPHyHFwjeBUD2m86A0WMhGv0opUGmlot7u/FgXuDtvphVipxbSDtKMB3Jfc uR/gTOc1SaIQPwp4RDf3ilIABv04f22iCxEWnLvmWvB9NnxE8ibE1f7RK7cp31Vl/S74 /FG5yzx51Zib8gHzLrUz1n07TlrCi2NO02iTHJERcy1OzFXXV3r/R3MAmWwSvytEz9t3 hSxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=lvtAxxkT5ADxtwuXzIeH0UltaEOLDURpLXOOrqJ/x9U=; b=sUYaSiwH2tKFizpOxRpGWcHIPGqauj5w2jPnR6UVFH47nI4IMCAKYDPlDE/MD/SshM xky8gWIoSSmwIpt6prT6GJH1/x0zZ2wHYM6vKmHvwtxBEvMSiXfWLcG1LPNJKaS2CzKs RYP6YG0qmF28OdzFXXCLgQMKpmgIwXdz3ZAyCrO4UH1eOL090oI+UlSlU4CuEcqvs755 OLBj6pcb6Jzy1j5wZeFawy/FL2hK++A+qfyGftn97pkYFhSgYinVCKqftwIMx4g9EhPA jRo2IpGx4QLl5bsJG4mdVeqZgIS7Hyh42vMN/kae06qxeuriebhekkfv9C3fg8u0qHsV scJw== X-Gm-Message-State: AJcUukfFEk0EuVvwJnHvwVPuzMS4OuZsmv918xpjG8wwlWttIWA988ig OPGcGMvppwLRXfF6ydbfzEL2KbWU X-Google-Smtp-Source: ALg8bN6WgJSZFQZXKQ6/hwyobhHq9aKOtpARrxpYzXA5TLC+k8zhkjSdBr3pugN5S48YpZ2zssOgNw== X-Received: by 2002:a24:4706:: with SMTP id t6mr15756235itb.109.1548891327364; Wed, 30 Jan 2019 15:35:27 -0800 (PST) Received: from hammer.magicstack.net (toroon12-3096784575.sdsl.bell.ca. [184.149.46.191]) by smtp.gmail.com with ESMTPSA id o192sm1985257itb.31.2019.01.30.15.35.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 15:35:26 -0800 (PST) Sender: Elvis Pranskevichus From: Elvis Pranskevichus To: Tom Lane Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH] Allow anonymous rowtypes in function return column definition Date: Wed, 30 Jan 2019 18:35:25 -0500 Message-ID: <5580575.Bn2KaDtcXf@hammer.magicstack.net> In-Reply-To: <19439.1548889181@sss.pgh.pa.us> References: <11038447.kQ5A9Uj5xi@hammer.magicstack.net> <1691096.MngoxCRQ0q@hammer.magicstack.net> <19439.1548889181@sss.pgh.pa.us> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wednesday, January 30, 2019 5:59:41 PM EST Tom Lane wrote: > I still found this pretty disjointed. After a bit of thought I > propose the attached reformulation, which has the callers just tell > the routines which types to allow explicitly, with the justification > comments living at the call sites instead of within the routines. This is a much better formulation, thank you! Elvis