From: Nikolay Shaplov <dhyan@nataraj.su>
To: vignesh C <vignesh21@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>,
 Michael Paquier <michael@paquier.xyz>,
 Amit Langote <amitlangote09@gmail.com>,
 Ian Lawrence Barwick <barwick@gmail.com>
Subject: Re: [PATCH] New [relation] option engine
Date: Wed, 01 Feb 2023 12:27:10 +0300
Message-ID: <55843546.Gl5gMapaBX@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <20230201090426.q5jheyvzcnlxyx5d@alvherre.pgsql>
References: <20230201090426.q5jheyvzcnlxyx5d@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart10880297.4lEFpmTqNO";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: 
 <https://www.postgresql.org/message-id/55843546.Gl5gMapaBX%40thinkpad-pgpro>
Precedence: bulk

--nextPart10880297.4lEFpmTqNO
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Nikolay Shaplov <dhyan@nataraj.su>
To: vignesh C <vignesh21@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>, Michael Paquier <michael@paquier.xyz>, Amit Langote <amitlangote09@gmail.com>, Ian Lawrence Barwick <barwick@gmail.com>
Subject: Re: [PATCH] New [relation] option engine
Date: Wed, 01 Feb 2023 12:27:10 +0300
Message-ID: <55843546.Gl5gMapaBX@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <20230201090426.q5jheyvzcnlxyx5d@alvherre.pgsql>
References: <20230201090426.q5jheyvzcnlxyx5d@alvherre.pgsql>

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D1=81=D1=80=D0=B5=
=D0=B4=D0=B0, 1 =D1=84=D0=B5=D0=B2=D1=80=D0=B0=D0=BB=D1=8F 2023 =D0=B3. 12:=
04:26 MSK =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=
=BB=D1=8C Alvaro Herrera=20
=D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
> On 2023-Jan-31, vignesh C wrote:
> > On Tue, 3 Jan 2023 at 18:38, vignesh C <vignesh21@gmail.com> wrote:
> > > The patch does not apply on top of HEAD as in [1], please post a reba=
sed
> > > patch: =3D=3D=3D Applying patches on top of PostgreSQL commit ID
> > > 92957ed98c5c565362ce665266132a7f08f6b0c0 =3D=3D=3D
> > > =3D=3D=3D applying patch ./new_options_take_two_v03f.patch
> > > patching file src/include/access/reloptions.h
> > > Hunk #1 FAILED at 1.
> > > 1 out of 4 hunks FAILED -- saving rejects to file
> > > src/include/access/reloptions.h.rej
> >=20
> > There has been no updates on this thread for some time, so this has
> > been switched as Returned with Feedback. Feel free to open it in the
> > next commitfest if you plan to continue on this.
>=20
> Well, no feedback has been given, so I'm not sure this is a great
> outcome.  In the interest of keeping it alive, I've rebased it.  It
> turns out that the only conflict is with the 2022 -> 2023 copyright line
> update.
>=20
> I have not reviewed it.
Guys sorry, I am totally unable to do just anything this month... Do not ha=
ve=20
spare resources to switch my attention to anything even this simple...

Hope, next month will be better... And I will try to do some more reviewing=
 of=20
other patches...

=2D-=20
Nikolay Shaplov aka Nataraj
=46uzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

--nextPart10880297.4lEFpmTqNO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE+sk3ebqQKlezKOi8PMbfuIHAGpgFAmPaMG4ACgkQPMbfuIHA
Gph8+ggAlRQQmQd0rsn2/LMiOimcSz9XQHexVTlceRKaBQOmxUSJzPiy3C5NYxUB
EuaS9JLajGK0Hq33pbOZIMoBAiD8j31Mkms1srax5G10v3M3EZ1PN4YoY5PIMB3M
Umblo+GrpQ1YPGJlDX1LZZpZBvbjtzwKfvnKc7TP1hcN0e+ViAOeP3/dI4HXR862
O9flGwSm9oB6qZ6ybCaWoIijkXQHhjELkdMcVdXNLMPLv9Y83eBEiFdWjD47rG+f
TeOsBAFpkyNc3X8wDqPa04rnqCSt6EfWBVFTUJfcu+M8MtyfezFAF/GRwLrDZQ9f
EKb85f3OowgcpX5rSYVZEYtqAgAkRg==
=zVDU
-----END PGP SIGNATURE-----

--nextPart10880297.4lEFpmTqNO--