Feedback-ID: i131946ab:Fastmail
Content-Type: multipart/mixed; boundary="------------tZKMGbleWAyzK05huyTbzq0I"
Message-ID: <55960a32-fabd-3473-d965-92692d753648@enterprisedb.com>
Date: Wed, 1 Jun 2022 06:55:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [RFC] building postgres with meson -v8
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
References: <20220328195913.rz3bllzhr26innoi@alap3.anarazel.de>
 <498f4933-7fa9-6815-7574-1d3b2ec85daf@dunslane.net>
 <1037188.1648508299@sss.pgh.pa.us>
 <20220328231140.7ylalxc76zli6p46@alap3.anarazel.de>
 <ada92faf-77b5-30b9-669b-ba0899ef7b42@enterprisedb.com>
 <20f604f6-40be-e17b-87ac-32737743c63d@enterprisedb.com>
 <20220429174633.6io23mlwphdqdakv@alap3.anarazel.de>
 <8ced34e6-7abf-b3b2-3770-0487794753c5@enterprisedb.com>
 <20220502163602.smlwfhh2cnutxora@alap3.anarazel.de>
 <b6176b65-a138-be7e-291f-ffbddd663ed1@enterprisedb.com>
 <20220506212724.yyga36l3pg42y3j7@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220506212724.yyga36l3pg42y3j7@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/55960a32-fabd-3473-d965-92692d753648%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------tZKMGbleWAyzK05huyTbzq0I
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 06.05.22 23:27, Andres Freund wrote:
> I added pkgconfig since then. They're not exactly the same, but pretty close,
> except for one thing: Looks like some of the ecpg libraries really should link
> to some other ecpg libs? I think we're missing something there... That then
> leads to missing requirements in the .pc files.

I took a closer look at the generated pkgconfig files.  I think they are 
ok.  There are a couple of insignificant textual differences that we 
could reduce by patching Makefile.shlib.  But technically they are ok.

There is one significant difference: the ecpg libraries now get a 
Requires.private for openssl, which I think is technically correct since 
both libpgcommon and libpgport require openssl.

Attached is a tiny patch to make the description in one file backward 
consistent.
--------------tZKMGbleWAyzK05huyTbzq0I
Content-Type: text/plain; charset=UTF-8;
 name="0001-fixup-meson-Add-meson-based-buildsystem.patch"
Content-Disposition: attachment;
 filename="0001-fixup-meson-Add-meson-based-buildsystem.patch"
Content-Transfer-Encoding: base64

RnJvbSA4MzIwYzUyMGUwMWI1MjkzM2Y2Njg4ZTIxMGZmYTljZGZkZWZmZmU5IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVHVlLCAzMSBNYXkgMjAyMiAyMDo0NjoyMCArMDIwMApTdWJqZWN0
OiBbUEFUQ0hdIGZpeHVwISBtZXNvbjogQWRkIG1lc29uIGJhc2VkIGJ1aWxkc3lzdGVtLgoK
Rml4IGRlc2NyaXB0aW9uIGluIHBrZy1jb25maWcgZmlsZSBmb3IgYmFja3dhcmQgY29uc2lz
dGVuY3kuCi0tLQogc3JjL2ludGVyZmFjZXMvZWNwZy9jb21wYXRsaWIvbWVzb24uYnVpbGQg
fCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK
CmRpZmYgLS1naXQgYS9zcmMvaW50ZXJmYWNlcy9lY3BnL2NvbXBhdGxpYi9tZXNvbi5idWls
ZCBiL3NyYy9pbnRlcmZhY2VzL2VjcGcvY29tcGF0bGliL21lc29uLmJ1aWxkCmluZGV4IDNj
ZDYxMjE3ZTMuLjg0Y2Q0MmNjZWUgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2VjcGcv
Y29tcGF0bGliL21lc29uLmJ1aWxkCisrKyBiL3NyYy9pbnRlcmZhY2VzL2VjcGcvY29tcGF0
bGliL21lc29uLmJ1aWxkCkBAIC0xMSw2ICsxMSw2IEBAIGVjcGdfY29tcGF0ID0gYm90aF9s
aWJyYXJpZXMoJ2VjcGdfY29tcGF0JywKIHBrZ2NvbmZpZy5nZW5lcmF0ZSgKICAgZWNwZ19j
b21wYXQuZ2V0X3NoYXJlZF9saWIoKSwKICAgbmFtZTogJ2xpYmVjcGdfY29tcGF0JywKLSAg
ZGVzY3JpcHRpb246ICdQb3N0Z3JlU1FMIGVjcGdfY29tcGF0IGxpYnJhcnknLAorICBkZXNj
cmlwdGlvbjogJ1Bvc3RncmVTUUwgbGliZWNwZ19jb21wYXQgbGlicmFyeScsCiAgIHVybDog
cGdfdXJsLAogKQotLSAKMi4zNi4xCgo=

--------------tZKMGbleWAyzK05huyTbzq0I--