From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Alexey Kondratov <a.kondratov@postgrespro.ru>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Free port choosing freezes when PostgresNode::use_tcp is used on
 BSD systems
In-reply-to: <519ddb94-f3ac-e9cc-3a61-7003c26f62f8@dunslane.net>
References: <20210127213658.GA736@alvherre.pgsql>
 <55c6c1526b94d2caf54c33262fe00674@postgrespro.ru>
 <e15777decc533006c9dbe4988bd66d31@postgrespro.ru>
 <YBTC0IYIGmyYfiIn@paquier.xyz>
 <1c506564e2a732ec17790bd8c34f042e@postgrespro.ru>
 <YBiro+n0767QDXSA@paquier.xyz> <YBpEsxZxIVn0zyFM@paquier.xyz>
 <66bad38beb87fb32952d89602e467444@postgrespro.ru>
 <82e271a9a11928337fcb5b5e57b423c0@postgrespro.ru>
 <459595.1618874567@sss.pgh.pa.us>
 <519ddb94-f3ac-e9cc-3a61-7003c26f62f8@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Tue, 20 Apr 2021 10:59:32 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <559791.1618931011.1@sss.pgh.pa.us>
Date: Tue, 20 Apr 2021 11:03:31 -0400
Message-ID: <559792.1618931011@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/559792.1618931011%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 4/19/21 7:22 PM, Tom Lane wrote:
>> I wonder whether we could get away with just replacing the $use_tcp
>> test with $TestLib::windows_os.  It's not really apparent to me
>> why we should care about 127.0.0.not-1 on Unix-oid systems.

> Yeah
> The comment is a bit strange anyway - Cygwin is actually going to use
> Unix sockets, not TCP.
> I think I would just change the test to this: $use_tcp &&
> $TestLib::windows_os.

Works for me, but we need to revise the comment to match.

			regards, tom lane