Message-ID: <55A99E07.3050905@gmx.net>
Date: Fri, 17 Jul 2015 20:29:59 -0400
From: Peter Eisentraut <peter_e@gmx.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Petr Jelinek <petr@2ndquadrant.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_resetsysid
References: <557D9DED.2080204@2ndquadrant.com>
In-Reply-To: <557D9DED.2080204@2ndquadrant.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 6/14/15 11:29 AM, Petr Jelinek wrote:
> 0002 - Adds pg_resetsysid utility which changes the system id to newly
> generated one.
> 
> 0003 - Adds -s option to pg_resetxlog to change the system id to the one
> specified - this is separate from the other one as it can be potentially
> more dangerous.

Adding a new top-level binary creates a lot of maintenance overhead
(e.g., documentation, man page, translations, packaging), and it seems
silly to create a new tool whose only purpose is to change one number in
one file.  If we're going to have this in pg_resetxlog anyway, why not
create another option letter to assigns a generated ID?  As the
documentation says, resetting the system ID clears the WAL, so it's not
like this is a completely danger-free situation.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers