Message-ID: <55b992da-c362-7474-1251-e1fe34eb136b@iki.fi>
Date: Thu, 23 Feb 2023 15:43:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: pg_rewind race condition just after promotion
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
 Ian Lawrence Barwick <barwick@gmail.com>, Daniel Gustafsson
 <daniel@yesql.se>, Ibrar Ahmed <ibrar.ahmad@gmail.com>
References: <9f568c97-87fe-a716-bd39-65299b8a60f4@iki.fi>
 <CALtqXTdD_V1+NtC3CJG=mxph4MskRbu8gyASSMxGSBn76Sp7ng@mail.gmail.com>
 <162626420228.1167.13414583689741111142.pgcf@coridan.postgresql.org>
 <492590F3-9566-4AC2-986D-6CFB35B110CD@yesql.se>
 <CAB8KJ=iNTR6NOSd=EVmSqcGURNbyO9ah3tKZtz1p8KzNzc1ugA@mail.gmail.com>
 <848e03ce-0c16-2166-3994-f2c3dcf467d0@iki.fi>
In-Reply-To: <848e03ce-0c16-2166-3994-f2c3dcf467d0@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/55b992da-c362-7474-1251-e1fe34eb136b%40iki.fi>
Precedence: bulk

On 22/02/2023 16:00, Heikki Linnakangas wrote:
> On 11/12/2022 02:01, Ian Lawrence Barwick wrote:
>> 2021年11月9日(火) 20:31 Daniel Gustafsson <daniel@yesql.se>:
>>>
>>>> On 14 Jul 2021, at 14:03, Aleksander Alekseev <aleksander@timescale.com> wrote:
>>>>
>>>> The following review has been posted through the commitfest application:
>>>> make installcheck-world:  tested, passed
>>>> Implements feature:       tested, passed
>>>> Spec compliant:           tested, passed
>>>> Documentation:            tested, passed
>>>>
>>>> The v3 patch LGTM. I wonder if we should explicitly say in pg_rewind tests that
>>>> they _don't_ have to call `checkpoint`, or otherwise, we will lose the test
>>>> coverage for this scenario. But I don't have a strong opinion on this one.
>>>>
>>>> The new status of this patch is: Ready for Committer
>>>
>>> Heikki, do you have plans to address this patch during this CF?
>>
>> Friendly reminder ping one year on; I haven't looked at this patch in
>> detail but going by the thread contents it seems it should be marked
>> "Ready for Committer"? Moved to the next CF anyway.
> 
> Here's an updated version of the patch.
> 
> I renamed the arguments to findCommonAncestorTimeline() so that the
> 'targetHistory' argument doesn't shadow the global 'targetHistory'
> variable. No other changes, and this still looks good to me, so I'll
> wait for the cfbot to run on this and commit in the next few days.

Pushed. I decided not to backpatch this, after all. We haven't really 
been treating this as a bug so far, and the patch didn't apply cleanly 
to v13 and before.

- Heikki