MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Sun, 19 Jan 2020 18:32:58 +0100
From: Erik Rijkers <er@xs4all.nl>
To: =?UTF-8?Q?=E6=9B=BE=E6=96=87=E6=97=8C=28=E4=B9=89=E4=BB=8E=29?=
 <wenjing.zwj@alibaba-inc.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Tomas Vondra
 <tomas.vondra@2ndquadrant.com>, Konstantin Knizhnik
 <k.knizhnik@postgrespro.ru>, Robert Haas <robertmhaas@gmail.com>, Julien
 Rouhaud <rjuju123@gmail.com>, Dean Rasheed <dean.a.rasheed@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>, =?UTF-8?Q?=E8=94=A1?=
 =?UTF-8?Q?=E6=9D=BE=E9=9C=B2=28=E5=AD=90=E5=98=89=29?= <zijia@taobao.com>,
 "Cai, Le" <le.cai@alibaba-inc.com>, =?UTF-8?Q?=E8=90=A7=E5=B0=91?=
 =?UTF-8?Q?=E8=81=AA=28=E9=93=81=E5=BA=B5=29?= <shaocong.xsc@alibaba-inc.com>
Subject: Re: [Proposal] Global temporary tables
In-Reply-To: <3A07073C-AF60-4C5E-859F-81A82911B671@alibaba-inc.com>
References: <1A1A6EDC-D0EC-47B0-BD21-C2ACBAEA65E4@alibaba-inc.com>
 <0ef6f482-11ce-a99f-207e-26fa3f2f56db@postgrespro.ru>
 <CA+Tgmob_Fg9PfNjjOReJtAE4B5gc8+UqHh+tztJ_C+iRN4KHSw@mail.gmail.com>
 <24099f4e-742c-e92b-729c-77bac1ca80d4@postgrespro.ru>
 <CAFj8pRBo8YZ=bJESqf2fkxGL8Bq2Fs7=SjxisS7UhXHh6yPSfA@mail.gmail.com>
 <80cf30c2-ebd5-a568-9f62-a970e4d91326@postgrespro.ru>
 <5767433E-1A77-4682-B3FD-4869911021C8@alibaba-inc.com>
 <6b7570aa-14ea-2f28-c3b5-74dd785bbafe@postgrespro.ru>
 <20200105200603.wrb4beacwb57hhpk@development>
 <C2F6C122-7951-400B-B708-FC4798A316D5@alibaba-inc.com>
 <CAFj8pRDTkjSWeyonnc8usDPJ4GybmqNV2R_1vb6hz4ZX9cjncw@mail.gmail.com>
 <B37B2282-0735-41FE-8C3B-BE54763F21A5@alibaba-inc.com>
 <CAFj8pRCFMfY8ZTztNP_mhd7PaFddiEKRhEUn7jE=AHcpjWxOLA@mail.gmail.com>
 <3A07073C-AF60-4C5E-859F-81A82911B671@alibaba-inc.com>
Message-ID: <55cfa22b53c89a75cebcb40eb245c999@xs4all.nl>
User-Agent: XS4ALL Webmail
Precedence: bulk

On 2020-01-19 18:04, 曾文旌(义从) wrote:
>> 2020年1月14日 下午9:20，Pavel Stehule <pavel.stehule@gmail.com> 写道：
>> út 14. 1. 2020 v 14:09 odesílatel 曾文旌(义从) <wenjing.zwj@alibaba-inc.com 
>> <mailto:wenjing.zwj@alibaba-inc.com>> napsal:

>> [global_temporary_table_v4-pg13.patch ]

Hi,

This patch doesn't quiet apply for me:

patching file src/backend/access/common/reloptions.c
patching file src/backend/access/gist/gistutil.c
patching file src/backend/access/hash/hash.c
Hunk #1 succeeded at 149 (offset 3 lines).
patching file src/backend/access/heap/heapam_handler.c
patching file src/backend/access/heap/vacuumlazy.c
patching file src/backend/access/nbtree/nbtpage.c
patching file src/backend/access/table/tableam.c
patching file src/backend/access/transam/xlog.c
patching file src/backend/catalog/Makefile
Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file 
src/backend/catalog/Makefile.rej
[...]
    (The rest applies without errors)

src/backend/catalog/Makefile.rej contains:

------------------------
--- src/backend/catalog/Makefile
+++ src/backend/catalog/Makefile
@@ -44,6 +44,8 @@ OBJS = \
  	storage.o \
  	toasting.o

+OBJS += storage_gtt.o
+
  BKIFILES = postgres.bki postgres.description postgres.shdescription

  include $(top_srcdir)/src/backend/common.mk
------------------------

Can you have a look?


thanks,

Erik Rijkers