Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7VbH-005dqd-1v for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Nov 2023 07:00:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r7VbD-00BD1O-7G for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Nov 2023 07:00:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7VbC-00BD1G-Tp for pgsql-hackers@lists.postgresql.org; Mon, 27 Nov 2023 07:00:06 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r7VbA-008kDm-QS for pgsql-hackers@lists.postgresql.org; Mon, 27 Nov 2023 07:00:06 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2c88b7e69dfso46636651fa.0 for ; Sun, 26 Nov 2023 23:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701068403; x=1701673203; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WPN3GQpaScblHgulc3ANbphJ4DZD+0mBBZPEcMnKMAI=; b=TUp0eBRxRVTvOImjmDAvc6jf+uZ4v5Ut/t9J2zELoUKenFMo86QLq1reyRDo0BoaQI 9qtc5kDiGDyrkIi4rWSWhJV6vEqCMk8g34OpE1xmKy/7HRTkMk1v4O9UCddHqTls7ZcR pIfBDWqwpGtUPrOebtOkIgUnm6mlbRWnAF54h6da2OjnEhrY4rWgYNfWPhFjrkLL14E5 H32PurxvoLGi4tQUtMOtzJtH3riiLAxQiA0SnlGFx2tUOIS70/0R4jrOzjRfAOqz1mex Q+pwSieF1rQGk0Qm1TTmRWE1lMKPwfLrwoC2MrsL0xfedTf3U2batk6IoAi+WWVnOYez LdIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701068403; x=1701673203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WPN3GQpaScblHgulc3ANbphJ4DZD+0mBBZPEcMnKMAI=; b=iypRB7rOUR1mvts+HhHOtpL4kcZIc18MHxZf1K39krPSCucwrNCg1KY5YNlxlRjrWZ j3Y0/x5Ve2G6BEG5g/VXNIK0PPu40SgMrRZ7nLAS45xH/Vpdp6JwYblOnorAO8NKrush +29qVnW47eGpMO+giIZ08zFbOje9y2HxLFJTmGsevx/v/sYtLy2M5kime7YrbDvqFV47 q2IfSXkBfetEKlV9xj87xxDZuGIxvrjWo6wigOJpticI1QmK68EgDpHuLlcolacIVzvC o0r9dDesbvXSCvMW6sg5tQz+tWNJhvyZWFQL20jo/k+b8drbvxzPd/wtp+TuR133eprD Xvgw== X-Gm-Message-State: AOJu0Yyeq7DFkEybrY0pxvSY9yv0U9QN1T8roJo9oXRHAlmVy1WOTCgC 0htgS1+ySckTnOz2jLkuetc= X-Google-Smtp-Source: AGHT+IEqUoMqfxJOnn1Km8LvV3YwjssUYHCgcvg+OtG2Bjn/RdHWh25p6zuj0J06/6xnG61L4hai7w== X-Received: by 2002:a2e:989a:0:b0:2c5:1e3f:7379 with SMTP id b26-20020a2e989a000000b002c51e3f7379mr6598092ljj.48.1701068402874; Sun, 26 Nov 2023 23:00:02 -0800 (PST) Received: from [1.0.0.7] ([178.155.26.96]) by smtp.gmail.com with ESMTPSA id t11-20020a2e9d0b000000b002c99895d8c7sm567491lji.5.2023.11.26.23.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Nov 2023 23:00:02 -0800 (PST) Message-ID: <55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com> Date: Mon, 27 Nov 2023 10:00:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) Content-Language: en-US To: Alexander Korotkov , Maxim Orlov Cc: Aleksander Alekseev , Postgres hackers , Heikki Linnakangas , Japin Li , Andres Freund , Michael Paquier , Pavel Borisov , Peter Eisentraut References: <9fa7bef7-6a08-dd6e-b324-a69ccb30eb60@iki.fi> <4dd273c5-f594-1c04-3710-5811e62b18db@iki.fi> From: Alexander Lakhin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Alexander, 27.11.2023 02:43, Alexander Korotkov wrote: > v61 looks good to me. I'm going to push it as long as there are no objections. > I've looked at the patch set and found a typo: occured And a warning: $ CC=gcc-12 CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-clobbered -Wno-missing-field-initializers" ./configure -q && make -s slru.c:63:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]    63 | static int      inline       | ^~~~~~ Maybe it's worth fixing before committing... Best regards, Alexander