Feedback-ID: ie0a040ee:Fastmail
Message-ID: <55f40114-0b00-4c6d-919d-c58641133d2b@eisentraut.org>
Date: Thu, 9 Jul 2026 10:18:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Bug] Add the missing RTE_GRAPH_TABLE case to
 transformLockingClause()
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAHg+QDcE9wp6nOEC3SCRQ90nrCO=QF+OZq1MG8Qc6hnusmogqw@mail.gmail.com>
 <CAExHW5sQ5CfQeO4QXQaArRpD5FrUK_ndDAqHiQFg04DaC-+NaQ@mail.gmail.com>
 <CAJTYsWX8J2cUTCnVRwks0gJw4wiMCv_qVSxshFC9f8oh7Ch6JA@mail.gmail.com>
 <CAExHW5tGQCjWEdyhOHGMj32NAMObH--eZDGeoxKRS9O3Wv_7wQ@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAExHW5tGQCjWEdyhOHGMj32NAMObH--eZDGeoxKRS9O3Wv_7wQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/55f40114-0b00-4c6d-919d-c58641133d2b%40eisentraut.org>
Precedence: bulk

On 10.06.26 14:49, Ashutosh Bapat wrote:
>> Attached is v2-0001, rebased on master and addressing
>> the comments you added in case we plan on parking the feature
>> work for once v20 opens.
> Thanks. I revised it a bit. Reworded the commit message to describe
> user facing behaviour instead of the internals, which are quite
> obvious from the code changes. Other cases in transformLockingClause()
> don't mention XXX, they just have ereport(). Removed that comment.
> Also massaged comments in the test - we usually don't describe the
> expected behaviour or error when it is obvious from the output.
> Attached revised patch.

Committed.

I also modified the comment that said "ignore JOIN, SPECIAL, ..." to 
just say "ignore all other RTE kinds", because keeping that kind of list 
up to date is silly.  (RTE_SPECIAL hasn't existed in a long time.)