Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zeqsy-0006KC-0V for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 20:43:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zeqsx-0003KO-J7 for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 20:43:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zeqsw-0003KG-Va for pgsql-hackers@postgresql.org; Wed, 23 Sep 2015 20:43:27 +0000 Received: from mail-bl2on0064.outbound.protection.outlook.com ([65.55.169.64] helo=na01-bl2-obe.outbound.protection.outlook.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zeqst-0002Jc-Ib for pgsql-hackers@postgresql.org; Wed, 23 Sep 2015 20:43:26 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jim.Nasby@bluetreble.com; Received: from decina.local (70.113.16.71) by SN1PR11MB0685.namprd11.prod.outlook.com (10.163.207.143) with Microsoft SMTP Server (TLS) id 15.1.280.20; Wed, 23 Sep 2015 20:43:18 +0000 Subject: Re: Less than ideal error reporting in pg_stat_statements To: Peter Geoghegan References: <5601D354.5000703@BlueTreble.com> <5601E3D1.5010401@BlueTreble.com> CC: Pg Hackers From: Jim Nasby Message-ID: <56030EE0.4030008@BlueTreble.com> Date: Wed, 23 Sep 2015 15:43:12 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5601E3D1.5010401@BlueTreble.com> Content-Type: multipart/mixed; boundary="------------070307020202000303030006" X-Originating-IP: [70.113.16.71] X-ClientProxiedBy: BY1PR15CA0031.namprd15.prod.outlook.com (25.162.17.169) To SN1PR11MB0685.namprd11.prod.outlook.com (25.163.207.143) X-Microsoft-Exchange-Diagnostics: 1; SN1PR11MB0685; 2:Xgssnqk+JoMS4zabaIO3rpjkN/nAHhg0HiMY2jMmE5vlWEt4oj8IWCe0x17Uec7DzzKOCywtZgJ4mgTAeUvaNQDt/O5gD7VwVuQEOCDHXZbIhPozJ0p5Je83XSYm67eUc4KzddYRCHB1D1ftBuV6+SMdidpp/tSj05hnbLPClhg=; 3:cY0LNauIGsBwJ8Pt8ZEhf8QwqmRNwZnigFZjEkgUgsjWc2NjB7WP5VFK1swB5V3wie5gOwwP60RNDrS0SGALDUBZGInKloQXHISjGz/SUD5X/WkJi1iiFFIg3x4XOwe5+Sob/Q8qlulpE9DY6sbCiw==; 25:p0aDRRYpxy9oSju7cH9ryL+4q8yAb1EBNSDjNUXd1f5ZD+CmOPEmg0Zc5n9/mjdr90l6rUI8zCZvD+pTszZ4OI13nKAsI9j2rGfxRv6QyZ7J2cy9D15dx/oga+y6AIRGXRBffN7N4PLXhkOeNkM0q8fYKk6zY/vwhv7094KrF9kCv46uSu6s5ZlrGMkfEth4S552oLVJJfz7l/0bHYHkiFcQgHpW3LcU8mE49DLlagCIXYL9MA8lauIan2FIRxOH8pBkmaL0tH92vOZKUXVkNw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR11MB0685; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001); SRVR:SN1PR11MB0685; BCL:0; PCL:0; RULEID:; SRVR:SN1PR11MB0685; X-Microsoft-Exchange-Diagnostics: 1; SN1PR11MB0685; 4:QfHwMm58Q4/HCni+B2LhYOaLw0U4qjhDaNaU6pnwwGNpExUsuFpKxSFGqH/OAM5W3w7IwxoPZ5XngeYjDT4SEX5krzMGc/+pPR2A6pgICY/yM+XEZFpX23pbrS8KShLfCi3XWa+kl4+EPZYoZOU1cfCmOr5GxREd6EuDZbB7iiefpOO146xUIfuQf85HSSpY5bCl3Wi44bpj0TjRoDJZkPpHrRZIqV/sHjrVQtY+MaJF/SOPwlepGEr2h4qSSc9SR5pByEeWBxqRuhQw3DfBPuXrPoKOuGlGUtudBJ5mPB6I/tFErEtuwr1BNoUT7RfkQ2Nqbax0H7eDfpSzW+goiyjvgNgAMntuPmTSUiCqOJc= X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(24454002)(189002)(377454003)(199003)(479174004)(81156007)(76176999)(122386002)(77096005)(68736005)(87976001)(4001350100001)(59896002)(65806001)(66066001)(54356999)(92566002)(97736004)(87266999)(65956001)(40100003)(64706001)(4001540100001)(46102003)(16601075003)(36756003)(5001860100001)(5001830100001)(5000100001)(2950100001)(568964001)(65816999)(4610100001)(5890100001)(15975445007)(62966003)(77156002)(80316001)(189998001)(5007970100001)(19580395003)(21490400002)(110136002)(101416001)(5004730100002)(83506001)(84326002)(106356001)(5001920100001)(5001960100002)(512874002)(33656002)(50986999)(86362001)(99136001)(42186005)(105586002)(64126003)(85282002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR11MB0685; H:decina.local; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: bluetreble.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR11MB0685; 23:0hiR7gBKmjpET4hoRPqnnODVdkMexUfKUyOHDfyZ5?= =?us-ascii?Q?aa5R+GwgEEqzNbvIM0Wg8xC03wdc83MnkguqJ9y4oDAkMrPLyBgFYLA/vJZG?= =?us-ascii?Q?kOgN5gjE8obQmwfH9x0RpRQehhaNRKE5+/zP7CQVhEYc6Z0QPqJwXsYwOFk5?= =?us-ascii?Q?7FbxSzxjR8TX9WFEU7L7ymMhiGAkTr4lXNO9+MkpZMfgjfsIfNTnmY6RC7uX?= =?us-ascii?Q?yyIYtJ0pBk4WbbEAXHkQ22xJAuDM9KVekmm5lOLRmqv2n4To/ZD9te34yg29?= =?us-ascii?Q?h7mgwNfSb0rGZOLtJIo9AOf47ysQOz+4fDXwS8wSYjzXqjhBETB86Ky2g55v?= =?us-ascii?Q?yOrYcHH+EKjkEkCB8f/bGYc/ouV9HQaSbpW02HgxbQrEt/fTC1/6Q88ALGHa?= =?us-ascii?Q?TxdijiD74tkbEnY2tJDVakQWQw8hB1dc2oYstfZVsZZzcLLKX/c9CcjPQkVY?= =?us-ascii?Q?JomAStUtVlv1nKjxHfgAe+PGjeA2lRsFqxZvpLHGIjIwTOjQIUj+RYzcf6Nz?= =?us-ascii?Q?32LD7w4dNqGHOmBcsh4E+LD6DJFqQDhjXlyOYQtruQH0QzHRr1zpMkXvUYtS?= =?us-ascii?Q?ka0GOcrmtdQH7rWh17jAf/YiT1UZmw2DIi+a26gaFOnJPg/zkIO6cOACbgg4?= =?us-ascii?Q?xP5pueUF1+sbS5FrQDpXkWknXt0aJ2nwjdvfuZ9EbA0ABr50W6BML6yW1bcj?= =?us-ascii?Q?U/uTL0sl/LNd+tQFJD5awbTb18cjsK9tLgXfFF/85uKG9wF4NucwGc/AkQ0R?= =?us-ascii?Q?JKQ9hb5DdMcMh3las5tEKl3Tq7yWxjXDWzTlbm002fPzGFg4CgiHgoKbs9ar?= =?us-ascii?Q?SIBAY50LG3fV1RJiDRj+DPuycot4qrFSKcxsHqwVtA3PyzvZZv5IGZ4VbNYP?= =?us-ascii?Q?EX54ottRUEkikvq2nAFRGq2TjkSM7W9q3vxvyYaFHocn36fDTnXslyrxcCb3?= =?us-ascii?Q?XVf0IKpmMT34a08rzcGJ6v1qdMk4ESmNf4PIyQkhQntiBgyv46DDbBTMoi9g?= =?us-ascii?Q?e76mQx4e3mKa91mqmdZ0/RM01szUULMQaWRB4JoFIJk2IqzeDgz2IZ4FeZEI?= =?us-ascii?Q?nkflMEjOHa2Nvw5Szl8L83rlgrzgYZ5PXNlJ/FqIpFDYj7uuyFX43v2snnFh?= =?us-ascii?Q?4cN66SD75/6cwl+P3UZK1jgOTopawuYkDTTxd9rxiSuhGkWUvMuQqyubd1FT?= =?us-ascii?Q?6krQ6JuvCoaQJxah54fc3IPD2k3zaYX2ROYn0wTX+ZFDUakQuFA34MruMXZb?= =?us-ascii?Q?MxIBzOEqQelwp9d5QdERhXKyuX/V0P1N8zTqZQmavOwGOerj1P5im8iyFe46?= =?us-ascii?Q?8Q7UW3w8DV/CrxscVNdyDlAhy2lcl9SBw+2gF0xCb3zLq80VaKdBib/QwfHE?= =?us-ascii?Q?W1qTQEQUOu2oXq7TRAfEfYoVt6EANxdcnay2suOlZpyU4yAUkqx2LdOtCXd6?= =?us-ascii?Q?nd7cV77IVWpjdNkGVoC3zVLGmw9yntsMwjM1dPpMdM2959EAg9QBMb0Srkjw?= =?us-ascii?Q?SX1Wy8LS3ZisBcQmB/pQawrmBnaPOj8kt7Bi9lg+PUxs/bLIUCqVrqESfGbJ?= =?us-ascii?Q?0QfM+Yg081D+P9pWcA94bHJwKmKKjFhxch4BzboL7SoWwmLZX+b4SAMks3Z?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR11MB0685; 5:hj2VvzyeONgyiGk49wZhXC931ZfbcErmi7w826kiEDyXtwO2HTtzKS+Sn+hQRlQnut+iIy8nMECaF6hZZ6J/aK4AeYmdi896h2+UU0IPpTZOqBL+g65WVwYmteGIwzwgnEkQJniZTL2aKBk8C/Be6g==; 24:zRJuzDwufO9MTXxQ9xrwqfmyXy1DNn+Eh2g3DuQb093V796gUGDH/VqPb407ZJNsl+iMot/E8Pdfmp/uLZ9DwNygYi2aNB4jLZxNsRrefi4=; 20:HMAIJRjdTiJ2OvEUSPjCqjEF5YDsqkmsDBpd8WCPKbHWpSrBNsUjNA7x57jW9QMZdZWcctJMoUTFslmb98NbTA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: bluetreble.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2015 20:43:18.4814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR11MB0685 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --------------070307020202000303030006 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 9/22/15 6:27 PM, Jim Nasby wrote: >> + ereport(LOG, >> + (errcode(ERRCODE_OUT_OF_MEMORY), >> + errmsg("out of memory attempting to pg_stat_statement >> file"), >> + errdetail("file \"%s\": size %lld", PGSS_TEXT_FILE, >> stat.st_size))); >> >> Uh, what? > > Oops. I'll fix that and address David's concern tomorrow. New patch attached. I stripped the size reporting out and simplified the conditionals a bit as well. -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com --------------070307020202000303030006 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="patch.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch.diff" ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcGdfc3RhdF9zdGF0ZW1lbnRzL3BnX3N0 YXRfc3RhdGVtZW50cy5jIGIvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVudHMv cGdfc3RhdF9zdGF0ZW1lbnRzLmMKaW5kZXggNTliOGEyZS4uYzlkY2Q4OSAx MDA2NDQKLS0tIGEvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVudHMvcGdfc3Rh dF9zdGF0ZW1lbnRzLmMKKysrIGIvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVu dHMvcGdfc3RhdF9zdGF0ZW1lbnRzLmMKQEAgLTE4OTIsMTUgKzE4OTIsMjQg QEAgcXRleHRfbG9hZF9maWxlKFNpemUgKmJ1ZmZlcl9zaXplKQogCX0KIAog CS8qIEFsbG9jYXRlIGJ1ZmZlcjsgYmV3YXJlIHRoYXQgb2ZmX3QgbWlnaHQg YmUgd2lkZXIgdGhhbiBzaXplX3QgKi8KLQlpZiAoc3RhdC5zdF9zaXplIDw9 IE1heEFsbG9jU2l6ZSkKLQkJYnVmID0gKGNoYXIgKikgbWFsbG9jKHN0YXQu c3Rfc2l6ZSk7Ci0JZWxzZQotCQlidWYgPSBOVUxMOworCWlmIChzdGF0LnN0 X3NpemUgPiBNYXhBbGxvY1NpemUpCisJeworCQllcmVwb3J0KExPRywKKwkJ CSAJLyogSXMgdGhlcmUgYSBiZXR0ZXIgY29kZSB0byB1c2U/IElFOiBTUUxT VEFURSA1MzAwMCwgNTM0MDAgb3IgNTQwMDAgKi8KKwkJCQkoZXJyY29kZShF UlJDT0RFX09VVF9PRl9NRU1PUlkpLAorCQkJCSBlcnJtc2coInBnX3N0YXRf c3RhdGVtZW50IGZpbGUgaXMgdG9vIGxhcmdlIHRvIHByb2Nlc3MiKSwKKwkJ CQkgZXJyZGV0YWlsKCJmaWxlIFwiJXNcIiIsIFBHU1NfVEVYVF9GSUxFLnN0 X3NpemUpKSk7CisJCUNsb3NlVHJhbnNpZW50RmlsZShmZCk7CisJCXJldHVy biBOVUxMOworCX0KKworCWJ1ZiA9IChjaGFyICopIG1hbGxvYyhzdGF0LnN0 X3NpemUpOworCiAJaWYgKGJ1ZiA9PSBOVUxMKQogCXsKIAkJZXJlcG9ydChM T0csCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9PVVRfT0ZfTUVNT1JZKSwKLQkJ CQkgZXJybXNnKCJvdXQgb2YgbWVtb3J5IikpKTsKKwkJCQkgZXJybXNnKCJv dXQgb2YgbWVtb3J5IGF0dGVtcHRpbmcgdG8gcmVhZCBwZ19zdGF0X3N0YXRl bWVudCBmaWxlIikpKTsKIAkJQ2xvc2VUcmFuc2llbnRGaWxlKGZkKTsKIAkJ cmV0dXJuIE5VTEw7CiAJfQo= --------------070307020202000303030006 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------070307020202000303030006--