Message-ID: <56042BC2.6030201@2ndquadrant.com>
Date: Thu, 24 Sep 2015 18:58:42 +0200
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Josh Berkus <josh@agliodbs.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
CC: Jeff Janes <jeff.janes@gmail.com>, Stephen Frost <sfrost@snowman.net>,
 Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Subject: Re: multivariate statistics / patch v7
References: <54C3FED3.1060600@2ndquadrant.com>
 <20150320.173307.249113775.horiguchi.kyotaro@lab.ntt.co.jp>
 <550C8E50.2010600@2ndquadrant.com>
 <20150324.143427.34552953.horiguchi.kyotaro@lab.ntt.co.jp>
 <5519E9B2.5080105@2ndquadrant.com>
 <CAMkU=1znGN-6-j9GAAM7XqgAYPNBfOMBWq5_6Hzym8bdVB4_iw@mail.gmail.com>
 <20150428161310.GR30322@tamriel.snowman.net>
 <CAMkU=1xrzZt3YGiux0tNkvXKGu4Jt3proMS+_X+UQhpB+qQ2Hw@mail.gmail.com>
 <553FCE56.2000008@2ndquadrant.com> <554A73A6.2060603@2ndquadrant.com>
 <55638982.40904@2ndquadrant.com>
 <WM!bdce762a9eb3c133829c01f4a03b823f03e911e18e83918d922f86f1fac1a39f3616449d62794182170e9765f10776f2!@asav-3.01.com>
 <56042827.6080602@agliodbs.com>
In-Reply-To: <56042827.6080602@agliodbs.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hi,

On 09/24/2015 06:43 PM, Josh Berkus wrote:
> Tomas,
>
>> attached is v7 of the multivariate stats patch. The main improvement is
>> major refactoring of the clausesel.c portion - splitting the awfully
>> long spaghetti-style functions into smaller pieces, making it much more
>> understandable etc.
>
> So presumably v7 handles varlena attributes as well, yes?   I have a
> destruction test case for correlated column stats, so I'd like to test
> your patch on it.

Yes, it should handle varlena OK. Let me know if you need help with 
that, and I'd like to hear feedback - whether it fixed your test case or 
not, etc.

regards

--
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers