From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Amit Khandekar <amitdkhan.pg@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: ArchiveEntry optional arguments refactoring
In-reply-to: <20190123172328.b6trpdpcbzbq4unv@alap3.anarazel.de>
References: <20190123164734.cnt7ho34ygwsav7z@alap3.anarazel.de>
 <201901231658.fls2whf2xypv@alvherre.pgsql>
 <20190123172328.b6trpdpcbzbq4unv@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 23 Jan 2019 09:23:28 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5605.1548264726.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Jan 2019 12:32:06 -0500
Message-ID: <5606.1548264726@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-01-23 13:58:07 -0300, Alvaro Herrera wrote:
>> It does.  How does pgindent behave with it?

> It craps out:
> Error@3649: Unbalanced parens
> Warning@3657: Extra )

> But that can be worked around with something like

>         te =3D ArchiveEntry(fout, tdinfo->dobj.catId, tdinfo->dobj.dumpI=
d,
>                           ARCHIVE_ARGS(.tag =3D tbinfo->dobj.name,
>                                        .namespace =3D tbinfo->dobj.names=
pace->dobj.name,
>                                        .owner =3D tbinfo->rolname,
>                                        .desc =3D "TABLE DATA",
>                                        .section =3D SECTION_DATA,
>                                        .copyStmt =3D copyStmt,
>                                        .deps =3D &(tbinfo->dobj.dumpId),
>                                        .nDeps =3D 1,
>                                        .dumpFn =3D dumpFn,
>                                        .dumpArg =3D tdinfo,
>                                        ));
> which looks mildly simpler too.

That looks fairly reasonable from here, but I'd suggest
ARCHIVE_OPTS rather than ARCHIVE_ARGS.

Can we omit the initial dots if we use a wrapper macro?  Would it be
a good idea to do so (I'm not really sure)?

			regards, tom lane