Message-ID: <560cca3781740bd69881bb07e26eb8f65b09792c.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Corey Huinker <corey.huinker@gmail.com>, Andres Freund
 <andres@anarazel.de>,  Michael Paquier <michael@paquier.xyz>, jian he
 <jian.universality@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>,
 Bruce Momjian <bruce@momjian.us>, Matthias van de Meent
 <boekewurm+postgres@gmail.com>, Magnus Hagander <magnus@hagander.net>,
 Stephen Frost <sfrost@snowman.net>, Ashutosh Bapat
 <ashutosh.bapat.oss@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 
 alvherre@alvh.no-ip.org
Date: Mon, 24 Feb 2025 12:20:41 -0800
In-Reply-To: <1471693.1740427438@sss.pgh.pa.us>
References: 
	<sdno5atrplq5b67vcx7x6fkzevwkzojd23izbguy2yma424wmp@siwbi3ijxdxs>
	 <x5yo5ly5u3dhzfaq3hrzeqhju3io5zmwk4yqrkge3ywcflffck@ghbbgsfv56yb>
	 <3670503.1740173078@sss.pgh.pa.us>
	 <blezfpeafycxlizyynwvwzh2vywmklhvfqudhicjrccu4raqpx@4ttfufowc2vo>
	 <3728741.1740178078@sss.pgh.pa.us>
	 <CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
	 <97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com>
	 <CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
	 <b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com>
	 <CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
	 <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
	 <CADkLM=d3H8xghP8QmOL6f_mBgP_X23-=2hOnYx7mqYiNSHimiQ@mail.gmail.com>
	 <bbdf2c731b5eda5deed427b2821e09109919595c.camel@j-davis.com>
	 <1471693.1740427438@sss.pgh.pa.us>
Content-Type: multipart/mixed; boundary="=-gyzDgxXp8NezPtlAuBYD"
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/560cca3781740bd69881bb07e26eb8f65b09792c.camel%40j-davis.com>
Precedence: bulk

--=-gyzDgxXp8NezPtlAuBYD
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2025-02-24 at 15:03 -0500, Tom Lane wrote:
> Jeff Davis <pgsql@j-davis.com> writes:
> > But you have a point in that float4in() does slightly more work
> > than
> > strtof() to handle platform differences about NaN/Inf. I'm not sure
> > how
> > much to weigh that concern, but I agree that there is non-zero
> > cognitive overhead here.
>=20
> If we're speaking strictly about the reltuples value, I'm not hugely
> concerned about that.=C2=A0 reltuples should never be NaN or Inf.

There actually is a concern here, in that the backend always has
LC_NUMERIC=3DC when doing float4in/out, but pg_dump does not. Patch
attached.

Regards,
	Jeff Davis


--=-gyzDgxXp8NezPtlAuBYD
Content-Disposition: attachment; filename="pg-dump-setlocale.diff"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name="pg-dump-setlocale.diff"; charset="UTF-8"

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19kdW1wLmMgYi9zcmMvYmluL3BnX2R1bXAv
cGdfZHVtcC5jCmluZGV4IDk1NTU1MGI5MWQyLi5lZDg1ZDg0M2Q1ZiAxMDA2NDQKLS0tIGEvc3Jj
L2Jpbi9wZ19kdW1wL3BnX2R1bXAuYworKysgYi9zcmMvYmluL3BnX2R1bXAvcGdfZHVtcC5jCkBA
IC01MjEsNiArNTIxLDkgQEAgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAJCXtOVUxMLCAw
LCBOVUxMLCAwfQogCX07CiAKKwkvKiBlbnN1cmUgdGhhdCBsb2NhbGUgZG9lcyBub3QgYWZmZWN0
IGZsb2F0aW5nIHBvaW50IGludGVycHJldGF0aW9uICovCisJc2V0bG9jYWxlKExDX05VTUVSSUMs
ICJDIik7CisKIAlwZ19sb2dnaW5nX2luaXQoYXJndlswXSk7CiAJcGdfbG9nZ2luZ19zZXRfbGV2
ZWwoUEdfTE9HX1dBUk5JTkcpOwogCXNldF9wZ2xvY2FsZV9wZ3NlcnZpY2UoYXJndlswXSwgUEdf
VEVYVERPTUFJTigicGdfZHVtcCIpKTsK


--=-gyzDgxXp8NezPtlAuBYD--