Message-ID: <5641923793cef7706395a34e62538b75d05e498b.camel@post.pl>
Subject: Re: Should consider materializing the cheapest inner path in
 consider_parallel_nestloop()
From: Tomasz Rybak <tomasz.rybak@post.pl>
To: pgsql-hackers@lists.postgresql.org
Cc: Tender Wang <tndrwang@gmail.com>, "Andrey M. Borodin"
 <x4mmm@yandex-team.ru>
Date: Thu, 30 May 2024 22:21:14 +0200
In-Reply-To: <CAHewXN=rP49ySfue9FA437jW4Me+FLBY-58zqTy+A_jxGGW=Xg@mail.gmail.com>
References: 
	<CAHewXNkPmtEXNfVQMou_7NqQmFABca9f4etjBtdbbm0ZKDmWvw@mail.gmail.com>
	 <CAMbWs49LbQF_Z0iKPRPnTHfsRECT7M-4rF6ft5vpW1ARSpBkPA@mail.gmail.com>
	 <CA+TgmobPBCvTHnBVn+a-=MS7pO_PUvtiLJkYo=BOrUjOxTss8g@mail.gmail.com>
	 <CAMbWs49agQ1THL0XYv_4aeZXN2R1cRksevja05n-MFOzZtNsuA@mail.gmail.com>
	 <CAHewXN=-XQwFY0n5EMUTzvK4G0aHWkNzdOPCfwnmQw3kDed2zQ@mail.gmail.com>
	 <9FBD029B-3E71-4D47-AB54-938C73A4668F@yandex-team.ru>
	 <CAHewXN=rP49ySfue9FA437jW4Me+FLBY-58zqTy+A_jxGGW=Xg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1-4 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/5641923793cef7706395a34e62538b75d05e498b.camel%40post.pl>
Precedence: bulk

On Tue, 2024-04-23 at 16:59 +0800, Tender Wang wrote:
>=20
[ cut ]
>=20
> I have rebased master and fixed a plan diff case.

We (me, Paul Jungwirth, and Yuki Fujii) reviewed this patch
at PgConf.dev Patch Review Workshop.
Here are our findings.

Patch tries to allow for using materialization together
with parallel subqueries.
It applies cleanly on 8fea1bd5411b793697a4c9087c403887e050c4ac
(current HEAD).
Tests pass locally on macOS and Linux in VM under Windows.
Tests are also green in cfbot (for last 2 weeks; they were
red previously, probably because of need to rebase).

Please add more tests.  Especially please add some negative tests;
current patch checks that it is safe to apply materialization. It would
be helpful to add tests checking that materialization is not applied
in both checked cases:
1. when inner join path is not parallel safe
2. when matpath is not parallel safe

This patch tries to apply materialization only when join type
is not JOIN_UNIQUE_INNER. Comment mentions this, but does not
explain why. So please either add comment describing reason for that
or try enabling materialization in such a case.

Best regards.

--=20
Tomasz Rybak, Debian Developer <serpent@debian.org>
GPG: A565 CE64 F866 A258 4DDC=C2=A0F9C7 ECB7 3E37 E887 AA8C