Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLZDk-00FawC-DJ for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Dec 2024 02:46:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tLZDh-005iYX-VB for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Dec 2024 02:46:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLZDh-005iYP-LV for pgsql-hackers@lists.postgresql.org; Thu, 12 Dec 2024 02:46:30 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLZDf-002NzI-Pw for pgsql-hackers@lists.postgresql.org; Thu, 12 Dec 2024 02:46:30 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4BC2kQvW564916; Wed, 11 Dec 2024 21:46:26 -0500 From: Tom Lane To: Peter Smith cc: PostgreSQL Hackers Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read. In-reply-to: References: <556792.1733967676@sss.pgh.pa.us> Comments: In-reply-to Peter Smith message dated "Thu, 12 Dec 2024 13:32:19 +1100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <564914.1733971586.1@sss.pgh.pa.us> Date: Wed, 11 Dec 2024 21:46:26 -0500 Message-ID: <564915.1733971586@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Smith writes: > The strange thing is there are other commands in that file very > similar to the ones I had changed but those already looked good, yet > they remained unaffected by the pgperltidy. Why? You sure it's not just luck-of-the-draw? I think that perltidy is just splitting the lines based on length, so sometimes related options would be kept together and sometimes not. regards, tom lane