Subject: Re: Logical replication and multimaster
To: Craig Ringer <craig@2ndquadrant.com>,
 konstantin knizhnik <k.knizhnik@postgrespro.ru>
References: <565C7756.9070604@postgrespro.ru>
 <CA+TgmoY1o3G0B-21zv2Pw5iEkpR8=J42GdsUOs4m0inKka3FEA@mail.gmail.com>
 <565F5208.3070100@postgrespro.ru>
 <CAMsr+YHMe=xs_E4fd2q1j7JPLpwvdU6+vY__rJTy2L4zkSSgTg@mail.gmail.com>
 <B58749EF-69B0-44F6-A2D3-0708BC92CFF7@postgrespro.ru>
 <CAMsr+YE+RDz-Lzj4ro7aRXKOPCb1dBisiiRbc2MbukBjMXzemA@mail.gmail.com>
Cc: pgsql-hackers Hackers <pgsql-hackers@postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>
From: Petr Jelinek <petr@2ndquadrant.com>
Message-ID: <56605A90.2010306@2ndquadrant.com>
Date: Thu, 3 Dec 2015 16:06:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: 
 <CAMsr+YE+RDz-Lzj4ro7aRXKOPCb1dBisiiRbc2MbukBjMXzemA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2015-12-03 14:32, Craig Ringer wrote:
> On 3 December 2015 at 15:27, konstantin knizhnik
> <k.knizhnik@postgrespro.ru <mailto:k.knizhnik@postgrespro.ru>> wrote:
>
>     3. What is the right way of creation of background worker requiring
>     access to shared memory, i.e. having control structure in main memory?
>
>
> This is documented and well established.
>
>     As far as I understand background workers have to be registered
>     either PG_init, either outside Postmaster environment.
>     If extension requires access to shared memory, then it should be
>     registered in shared_preload_libraries list and should be
>     initialized using shmem_startup hook.
>
>
> Correct.
>
> You can use dynamic shmem instead, but there are some issues there IIRC.
> Petr may have more to say there.
> Take a look at the BDR code for some examples, and there are some in
> contrib too I think.
>

If you have your own flock of dynamic workers that you manage yourself, 
it's probably easier to use dynamic shared memory. You can see some 
examples in the tests and also in the parallel query code for how to do 
it. The only real issue we faced with using dynamic shared memory was 
that we needed to do IPC from normal backends and that gets complicated 
when you don't have the worker info in the normal shmem.


The registration timing and working with normal shmem is actually not a 
problem. Just register shmem start hook in _PG_init and if you are 
registering any bgworkers there as well make sure you set bgw_start_time 
correctly (usually what you want is BgWorkerStart_RecoveryFinished). 
Then you'll have the shmem hook called before the bgworker is actually 
started.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers