From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Michael Paquier <michael@paquier.xyz>,
        Jacob Champion <pchampion@vmware.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
In-reply-to: <202106301258.xdrqcxocchyg@alvherre.pgsql>
References: <202106301258.xdrqcxocchyg@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Wed, 30 Jun 2021 08:58:31 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <566225.1625062172.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 30 Jun 2021 10:09:32 -0400
Message-ID: <566226.1625062172@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/566226.1625062172%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Maybe there's something about the linker flags being used.
> ... ah yeah, if I configure with coverage enabled on my machine, it fail=
s in the same way.

Ah-hah, yeah, I see it too if I enable profiling.  I can confirm
that it's not from the abort() call in path.c, because it's still
there if I remove that.  So this is another case where build
infrastructure is injecting abort() calls we didn't ask for.

Between this and the icc case, I'm now inclined to give up on
trying to forbid abort() calls in libpq.  I think the value-add
for that is a lot lower than it is for exit() anyway.  abort()
is something one doesn't toss around lightly.

You mentioned __gcov_exit, but I'm not sure if we need an
exception for that.  I see it referenced by the individual .o
files, but the completed .so has no such reference, so at least
on RHEL8 it's apparently satisfied during .so linkage.  Do you
see something different?

			regards, tom lane