From: Antonin Houska <ah@cybertec.at>
To: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
    Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
    Matthias van de Meent <boekewurm+postgres@gmail.com>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: 
 <CADzfLwURy8_BYyqrvr6rhTXsW3=5QMRLHuNati3CgY0nKRSwyw@mail.gmail.com>
References: 
 <CAFC+b6qk3-DQTi43QMqvVLP+sudPV4vsLQm5iHfcCeObrNaVyA@mail.gmail.com>
 <202603191855.fzsgsnyzfvpt@alvherre.pgsql>
 <CADzfLwURy8_BYyqrvr6rhTXsW3=5QMRLHuNati3CgY0nKRSwyw@mail.gmail.com>
Comments: In-reply-to Mihail Nikalayeu <mihailnikalayeu@gmail.com>
   message dated "Fri, 20 Mar 2026 13:35:00 +0100."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5666.1774513434.1@localhost>
Date: Thu, 26 Mar 2026 09:23:54 +0100
Message-ID: <5667.1774513434@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/5667.1774513434%40localhost>
Precedence: bulk

Mihail Nikalayeu <mihailnikalayeu@gmail.com> wrote:

> Hello, everyone!
> 
> Some comments for v43:

Thanks!

> ------------------------------
> 
> src/backend/catalog/index.c:766,1464-1469
> 
> "bool      progress = (flags & INDEX_CREATE_REPORT_PROGRESS) != 0;"
> 
> AFAIU gin, hash and btree (at least) still just unconditionally write
> PROGRESS_CREATEIDX_* progress.

I think you're right, I'll check it.

> src/backend/catalog/toasting.c:334
> 
> "INDEX_CREATE_IS_PRIMARY | INDEX_CREATE_REPORT_PROGRESS, 0,"
> 
> Should we add the "progress" flag too here and move it from make_new_heap?

Good catch. I'd prefer removing this hunk from the patch because the index on
the TOAST relation is created while it's still empty.

(The other commens have already been addressed by Alvaro.)

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com