Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qnNIC-00AlgX-GA for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Oct 2023 18:05:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qnGfc-00Aqxw-HS for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Oct 2023 11:01:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qnGaf-00AnOa-7w for pgsql-hackers@lists.postgresql.org; Mon, 02 Oct 2023 10:55:53 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qnEgA-007kkE-Ar for pgsql-hackers@lists.postgresql.org; Mon, 02 Oct 2023 08:53:27 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40566f89f6eso136505375e9.3 for ; Mon, 02 Oct 2023 01:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696236804; x=1696841604; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q+sB+lHrqm4G6pFIyHGihAjZF0AMJ1bwrmYaURG0CB8=; b=AoidiRvpoZEKsQxMVhGRfN+zG5jJebwQHxESNa95NY5ABO4ZRYe9/ni4cIiKWOWpSy F0QqWVMt3vrMHVeGCB4T2shwF1Ujyk3LjBPS6eoRlz+HxKpFEKWCYRGPO3cgEpmQF0aW pOd6lptO/eO13B3TSIRrepg1dMWl94FSqnd6vIvdACKpG++wsBbhJ+4A5RBzBz5eu+TZ 7+RehbXwQhPF5DirL/PSPgW9dqqop07OA/Ul7xXxf4g8aJbWmmTrml3Zuc4R6BVM+EaE eMGoqxTGrwkqahrg9d1gNHVYADcfscvQBGFwG9YrQDwC8igqTrJvAtJpHhsWFS4HWMVh v5rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696236804; x=1696841604; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q+sB+lHrqm4G6pFIyHGihAjZF0AMJ1bwrmYaURG0CB8=; b=TpaMupUJIYV/1EmceMhvbkt8NpECMWw46h2FRZOGX7o0j0d96yUcaCuIcfRhmNltOq UEae0mO2gJlZfSrnJCbxsGhoC1xDtJ7qUO9YKpHcblQGRQthXCmkzZdmkFQLc8bPB27V Y37wGQ0lemoqnLtsZP2rDQ4flZtdEM/Npsboilhh+sgX7aYsF5C7UK6xexmRSkP1kDvL iaxnxf5s56zhDe4T6GIDV3Mf52E9TgAb5qJ6TFh1qpPAhdaERpT4u5clCbLMPzqwGiKB mBkK9/rtb2w4orxPm72dNDfgHS05s5nMYHzTD9ROYCIIBCQ2GBViiDBX+llzljQIEqM2 driA== X-Gm-Message-State: AOJu0YwYOFnKjtJjpqOt85UYKCOLKOGf0tJcMB60flLKh5pzXl4pDeSC COuIC7bCdEZTjWwjuJWRhRo= X-Google-Smtp-Source: AGHT+IH9bxhfqJtHIwSvL3mdhdX9MZI2fDYL5jbRZTzTJssHB7rWt029+6Mt+X9XMaTPrp9cjChB3A== X-Received: by 2002:a05:600c:2242:b0:405:359e:ee43 with SMTP id a2-20020a05600c224200b00405359eee43mr9734310wmm.1.1696236803725; Mon, 02 Oct 2023 01:53:23 -0700 (PDT) Received: from ?IPV6:2a01:cb11:55e:1700:fdfb:2c20:5a8d:9c46? ([2a01:cb11:55e:1700:fdfb:2c20:5a8d:9c46]) by smtp.gmail.com with ESMTPSA id r1-20020a05600c298100b0040586360a36sm6770186wmd.17.2023.10.02.01.53.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 01:53:23 -0700 (PDT) Message-ID: <566c1686-c80b-4d4a-b496-b00ac428a095@gmail.com> Date: Mon, 2 Oct 2023 10:53:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag Content-Language: en-US To: Michael Paquier Cc: PostgreSQL Hackers References: From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 10/2/23 10:17 AM, Michael Paquier wrote: > On Mon, Oct 02, 2023 at 10:01:04AM +0200, Drouvot, Bertrand wrote: >> I think that would make sense to have more flexibility in the worker_spi >> module. I think that could be done in a dedicated patch though. I >> think it makes more sense to have the current patch "focusing" on >> this new flag (while adding a test about it without too much >> refactoring). What about doing the worker_spi module re-factoring >> as a follow up of this one? > > I would do that first, as that's what I usually do, The reason I was thinking not doing that first is that there is no real use case in the current worker_spi module test. > but I see also > your point that this is not mandatory. If you want, I could give it a > shot tomorrow to see where it leads. Oh yeah that would be great (and maybe you already see a use case in the current test). Thanks! >> Oh right, worth to modify 019_replslot_limit.pl, 002_corrupted.pl and >> 001_pg_controldata.pl in a separate patch for consistency? (they are using >> "(stat $node->logfile)[7]" or "(stat($pg_control))[7]"). > > Indeed, that's strange. Let's remove the dependency to stat here. > The other solution is slightly more elegant IMO, as we don't rely on > the position of the result from stat(). Agree, I will propose a new patch for this. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com