Feedback-ID: ie0a040ee:Fastmail
Message-ID: <5670bbe8-aee7-469e-b4c2-4b0bd61a090f@eisentraut.org>
Date: Tue, 17 Feb 2026 10:24:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Make copyObject work in C++
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>
References: <CAGECzQR21OnnKiZO_1rLWO0-16kg1JBxnVq-wymYW0-_1cUNtg@mail.gmail.com>
 <4d8b9e53-3f37-43f0-a4aa-5bda9c7961b3@eisentraut.org>
 <DFEUMBSUG8KA.XGY0CN9PFPR2@jeltef.nl> <DFKV26A4CHG2.CB7NJ1X62BKH@jeltef.nl>
 <fd1a4790-4fbc-43b4-a385-e3b98b9ed04d@eisentraut.org>
 <DFQYWIJD4L1J.3HQFOWSWKLFOR@jeltef.nl>
 <4e82f77b-acad-4356-94f6-8255135fb36b@eisentraut.org>
 <DFXOG2P1QMS8.3L7MCAL0E6MVJ@jeltef.nl>
 <ztktlrqatfj4roqhdjurccb3b4mf5hrycybfrzwupt4xmbwjt4@alrtyxhz5sns>
 <DFXV193BOBQ8.1BY2PK8YRJ9O1@jeltef.nl>
 <2h2n2gyw2f4ucicbl3drtdkjt2wzf6b2r4wqm7xwks6vpx5j7n@imymv4hkz5jz>
 <DGDRHFD14I7Z.30DSV2XVI6V93@jeltef.nl>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <DGDRHFD14I7Z.30DSV2XVI6V93@jeltef.nl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/5670bbe8-aee7-469e-b4c2-4b0bd61a090f%40eisentraut.org>
Precedence: bulk

On 13.02.26 11:28, Jelte Fennema-Nio wrote:
> On Sun Jan 25, 2026 at 9:06 PM CET, Andres Freund wrote:
>> Named args make that easier in two ways: First, only extensions using the
>> to-be-removed option will fail. Second, removal of options reliably 
>> generates
>> errors, rather than bogusly use one field for another, just because 
>> the types
>> are compatible.
> 
> After discussing the topic in-person with Peter at FOSDEM. We agreed
> that the best road forward was to not bother with MSVC for now. No-one
> has actually expressed an interest in being able to build C++ extension
> using MSVC, and the effort to support it is both non-trivial and not
> without downsides to the rest of the codebase. We can always come back
> to this later, possibly requiring C++20 on MSVC.
> 
> So I've removed that patch and now this patchset its goal is to improve
> compatibiltity with the C++ flavor of GCC and Clang.
> 
> Patch 1 and 2 add some more macro calls to our test C++ extension. These
> macros already work in GCC and Clang, this is purely to test for future
> regressinos.

I have committed these two.  I'll give them some time on the buildfarm 
and then look at the rest.