Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWk0S-0007eE-7Y for pgsql-hackers@arkaria.postgresql.org; Sun, 25 Oct 2020 17:40:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kWk0P-00073v-4a for pgsql-hackers@arkaria.postgresql.org; Sun, 25 Oct 2020 17:40:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWk0O-00073o-Ty for pgsql-hackers@lists.postgresql.org; Sun, 25 Oct 2020 17:40:32 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWk0M-00083B-JC for pgsql-hackers@postgresql.org; Sun, 25 Oct 2020 17:40:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 09PHeLvv567745; Sun, 25 Oct 2020 13:40:21 -0400 From: Tom Lane To: Noah Misch cc: Peter Geoghegan , Andres Freund , Phil Florent , PostgreSQL Hackers Subject: Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallel index creation & pg_stat_activity) In-reply-to: <20201025164246.GD2651494@rfd.leadboat.com> References: <20201014022636.GA1962668@rfd.leadboat.com> <20201025051836.GC2651494@rfd.leadboat.com> <439665.1603637570@sss.pgh.pa.us> <20201025164246.GD2651494@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Sun, 25 Oct 2020 09:42:46 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <567743.1603647621.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 25 Oct 2020 13:40:21 -0400 Message-ID: <567744.1603647621@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Noah Misch writes: > Each elog(FATAL) check deserves a STATEMENT field if it fires, so I thin= k that > would be too early to clear. Here's an version fixing the defects. In > worker_spi_main(), the timing now mirrors postgres.c. initialize_worker= _spi() > is doing something not directly possible from SQL, so I improvised there= . I'm good with this version. Thanks! regards, tom lane