Subject: Re: Additional LWLOCK_STATS statistics
To: Robert Haas <robertmhaas@gmail.com>
References: <55F82AE1.3010407@redhat.com>
 <CA+TgmoYvgL7rA6jBzn60FUeHhb5TH2xu2m9JKPiXFqbZ5Dyi7w@mail.gmail.com>
 <55F871BA.4060404@redhat.com>
 <CA+TgmoaXdUvA1P=-9PScZU5PMBEYeHw2XD4zF69=_LTU2zs+Wg@mail.gmail.com>
 <55F876CA.8020702@redhat.com> <55F97909.3010101@redhat.com>
 <55F97BF0.70503@redhat.com> <55F97EB7.8080308@redhat.com>
 <20150916162627.GF2086@alap3.anarazel.de> <55F99C65.4070209@redhat.com>
 <567136BF.6080804@redhat.com>
 <CA+Tgmob-6MosZ0PTjdn6yPjcQN161CWS-3-pq_-8dENCE-QSSg@mail.gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: JBoss, by Red Hat
Message-ID: <5677AF4C.10205@redhat.com>
Date: Mon, 21 Dec 2015 02:50:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: 
 <CA+Tgmob-6MosZ0PTjdn6yPjcQN161CWS-3-pq_-8dENCE-QSSg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 12/18/2015 01:16 PM, Robert Haas wrote:
> Is this just for informational purposes, or is this something you are
> looking to have committed?  I originally thought the former, but now
> I'm wondering if I misinterpreted your intent.  I have a hard time
> getting excited about committing something that would, unless I'm
> missing something, pretty drastically increase the overhead of running
> with LWLOCK_STATS...
>

Yeah, so unless other people using LWLOCK_STATS find the additional 
information of use (w/ the extra overhead), I think we can mark it as 
"Returned with feedback" or "Rejected".

Alternative, I can redo the patch requiring an additional #define - 
f.ex. LWLOCK_STATS_QUEUE_SIZES

Best regards,
  Jesper


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers