Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aFXM9-0002UQ-MX for pgsql-hackers@arkaria.postgresql.org; Sun, 03 Jan 2016 01:21:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aFXM7-0006F4-Hb for pgsql-hackers@arkaria.postgresql.org; Sun, 03 Jan 2016 01:21:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aFXKm-0004hq-G7 for pgsql-hackers@postgresql.org; Sun, 03 Jan 2016 01:19:48 +0000 Received: from mail-bl2on0065.outbound.protection.outlook.com ([65.55.169.65] helo=na01-bl2-obe.outbound.protection.outlook.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aFXKh-0001Ht-VS for pgsql-hackers@postgresql.org; Sun, 03 Jan 2016 01:19:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=BlueTreble.onmicrosoft.com; s=selector1-bluetreble-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8L2m4kai5ROJYfI1TDNMl6rNL5uJv1BZ78Ii2thiYKs=; b=B/yMQ/yNLhwAW+QkP70oJQsqwYHjwDzpyUaO4YJRYDllbBVl/TgoFva38g1AtgHFICicTDfz50UiqUysEtXhpTt2qhdK0VpAfBkYLipv7Svo9DuP0EAghWHRX3f2QNEj8gEgDK7CbfZZOHCzrmXSzjMtAux1fv2ZGgCIyXUOSz0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jim.Nasby@bluetreble.com; Received: from decina.att.net (2602:306:c4a9:2b00:edd1:cea5:b1e0:650) by BY2PR11MB0677.namprd11.prod.outlook.com (10.163.111.19) with Microsoft SMTP Server (TLS) id 15.1.361.13; Sun, 3 Jan 2016 01:19:39 +0000 Subject: Re: Improved error reporting in format() To: Pg Hackers References: <568863FC.9030209@BlueTreble.com> From: Jim Nasby Message-ID: <5688772A.3020309@BlueTreble.com> Date: Sat, 2 Jan 2016 19:19:38 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <568863FC.9030209@BlueTreble.com> Content-Type: multipart/mixed; boundary="------------040801020207020308050803" X-Originating-IP: [2602:306:c4a9:2b00:edd1:cea5:b1e0:650] X-ClientProxiedBy: BY2PR11CA0063.namprd11.prod.outlook.com (25.163.150.159) To BY2PR11MB0677.namprd11.prod.outlook.com (25.163.111.19) X-Microsoft-Exchange-Diagnostics: 1; BY2PR11MB0677; 2:twdBCGvxAzvQIt82CGC4cv58uNDxVVnbyDMbm6hsgeczNMSkPB/snOcRGqi8z2oA6wBdlhrOGgxJL5bmm2RT4+ZpzKKf0VAQZ/tgJorPtO4SLk31IWM48uRhmTbhtx9dB1nvX5qWErmcBS1IWwQK3g==; 3:sMS/SaWb5k0Xv/umRPVxvJ7EkVagckL6qs8wzN9xh39p9YfYnIBmKnxjS8x09XCjYVxpEQX41vPuE/ef4vM90tXkCodJCSU6rZ/meHs0yUSyfL0IXHbYyjapRMAW8hRP; 25:6stImozc0CdMRIJlrln6/dmt37eeQ910k/CCNRKf4tsWeoMsNrxVZRPKbt23WUCk1qsCbOpXZKgjTl839FSOFcvm11XtlRV6WDeFSgWINXeAGxSMN8X8bW89gJwJEbfk0UrlI160fmuEb3/dmYfAeUy5pYpqw2AIps9GhNvh+KERGbSfH/Mbd8YOKsX3XL8m58y6ctCDDjyMXTJHxAM+qoorhmFHUGunJrCGQgdqXfjus9s0iSHcqjID6Miqy7U34ttFhAjSrpAJ01es4xFfNw==; 20:QFJ+/0EyWiSLa+zJmCGiilIZxPLtuvmWkE5wH8C9I7nKlbne91TTj6UZi7qUcz8Xu6bgIvnxHkS1f++CF3YvhPtjzaVJVuZMdI3akO7c3rZbSLSAzmHrO3DSuhMCnwohZ9F77+Xt9Dopq/ayFb2OUiAjQ7vIscAaG3uBO+MkcNQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR11MB0677; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046); SRVR:BY2PR11MB0677; BCL:0; PCL:0; RULEID:; SRVR:BY2PR11MB0677; X-Microsoft-Exchange-Diagnostics: 1; BY2PR11MB0677; 4:zYk+RG7LG/1bb3CC5P4b/a8a2a0ux8LC+k8rQfv9AZOA3pkjA5CNWkLKmDiORGkdClCVO9tz2jleATiCN2fGTwq5LSHDkSUzXfXNrwffk1EX5I6gnO25eUOLw1QaBGChbjJ/O0uwyB1paziz9EGUXGLKFCJ+QyBzHC/0zbbuSgZf1rQ+RDn0wM00gPhKtr9tSYWThe5ejxVOxbtKZOZ7XzeEr5shoCLx5eSUWikzWjaHKxN/Myzg52rj7lkdkzXf1vgIVJTgSBhJwn20DsyJ4tL7f3U4G+MiTC49rTtEAvwz9mo7/J7+3SsivYR6hQuDHcxxPWkAik3/BLZfWNpBxQEzi5syN0ZxzOO/erYU5RElRgiQwtt2pCVMTavXOtMM X-Forefront-PRVS: 0810818DA0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(377454003)(479174004)(189002)(24454002)(199003)(97736004)(5004730100002)(512874002)(4610100001)(83506001)(59896002)(19580395003)(87976001)(2476003)(15975445007)(80316001)(106356001)(105586002)(21490400002)(40100003)(64126003)(76176999)(107886002)(450100001)(5000100001)(101416001)(189998001)(50986999)(4001350100001)(65816999)(99136001)(110136002)(87266999)(54356999)(1096002)(65806001)(42186005)(33656002)(6116002)(36756003)(84326002)(77096005)(586003)(5890100001)(16601075003)(2950100001)(568964002)(86362001)(122386002)(5008740100001)(53416004)(65956001)(270700001)(92566002)(3826002)(85282002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR11MB0677; H:decina.att.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: bluetreble.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR11MB0677; 23:FZrPnbS+Cmqjjc7TeP+oJNWNRrLMxKzWN/ZEIPV/E?= =?us-ascii?Q?D7YvkcXY0dWnwzeC95pNxA67XxFQZaFNtLmnSOz/kHaEsS/I81idONQXTVBA?= =?us-ascii?Q?HNzoD2oE1v2oOYxFM8WwE7SXsNAPLZlqJx9I+zoUk/Lc6UfuXZ/0e+zhSKa9?= =?us-ascii?Q?b0+kuC14VNm+4FwwfYCxqXp5FFTupqUU1br5zXpW+rC/a9Es69+IR4J9BAMu?= =?us-ascii?Q?cAl8KZ5B4REe+vWHajatk8jNI5Vkc/A8lo4Ewo6vSflQ+kjBt8AFaXDuEkGW?= =?us-ascii?Q?CBYrsWNyuDg75b+B2YvhKib8Q2iljXOiUn+Ya5OCX+OvzGriOGL8BhT5xqyv?= =?us-ascii?Q?8c9HdrkAiQJjx1cnfjYqAXLTAfN43qGhInjuoW5I6K6dqWDKmxGfqm2xJ6u0?= =?us-ascii?Q?H87X8k2J9fIyuBHQmkffpttHLLWRjABL3vvAuls823wMAm41aaOXQeUZlq8f?= =?us-ascii?Q?5CCg6teRWW1/NcKH056QIlrMr9yPsbsu1tpokzBL5BIRdcLSVYypB4GVRavn?= =?us-ascii?Q?RVtjIiLgRqEXs9qBlULp8QV3qVe++O1z81D5mhD+wLMmKYw1F7qGcwJ/T5aT?= =?us-ascii?Q?+bcbUUw4tR4WBtwTuerAG2BZf7YYRYanCzjgCfQ0BNNbDZwX1Fy1QO9aFsdN?= =?us-ascii?Q?TSp/OwkkWlFPXjlAzaUKgqgkuTVxxohOzRkRMsmGEy5EMnIe/3xjvAv8nWBq?= =?us-ascii?Q?Rj072mpMYY2AioypvrC0tlMvPaPL7Idv+40RL/kxKIoJGFV9ltzMPFC5FuBC?= =?us-ascii?Q?h+0VfozN9TaQdx9YmHrTztNNdoLT691Bh0qX+jtBJYvfTU4iLEPeTN+NGtM2?= =?us-ascii?Q?lpthtWZnzP6Y80zjiHewmjAEkgAYf0H11/LbYHqd7evGoQJxxbdj973p41RH?= =?us-ascii?Q?0XPK/A+TkHKb0Q6hjHnjXluFsNDU7a4pIiq9VIJCKKHy00Qj9mlcJK4yLU6D?= =?us-ascii?Q?kOLoc0qeu7GbfmqnjyihMoHFbvg1uElQPiFChIKFOL21DW8Af6N+16wG3qPQ?= =?us-ascii?Q?oKvW0IJ+uilXRMpv26ik9vuGswHBeZieZdWwfdZDhEEUTcBN9LchWCjZM+wt?= =?us-ascii?Q?qccq3K/IRDRmdrJbuKPYKWEqh54sZFpD2w1kk4cmVNhmq3mS6+lAgjY3H1dq?= =?us-ascii?Q?hjnaQVf6riLMfLL6GgA3ZWWqWHWUoPo5Kfzo8kIOjJpOXlvtjxiXWEkos5G+?= =?us-ascii?Q?W7ztv0EXzuosRfX4ezi299U6OoIfxMq3ylq6885diYu63gFe5+ZFSNlwzmdw?= =?us-ascii?Q?4ukl4MOVZBAef3B5aZlpUZ3/d5zqNMmD80X7+mM/UHG4rvLgKLwlMEIn42/p?= =?us-ascii?Q?1dNgRz/6BBkH5nplaix4rsPzXr5ZiMBZQhXn/+iplBtsEC4gzTzTrH+PhSR9?= =?us-ascii?Q?5SlTzT2r2SrWaZna9ffQoDBWHlqJz1OkR55ztVq0Fo0PRYoMq9KLe4Uw/2Ht?= =?us-ascii?Q?CvMh4pZLs8++hhNpA7QJ8QhzNc+81efSmlIckC2s0zCmkQwijN0?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR11MB0677; 5:yLiHUfLri0YlEHP6GwU+BRN7OsH+15OYdGLFHvGb0aN4bXiyChLqqI+Hb8XlqF5OF0uXfFYXdFzXGGeI/dIs10MTE54j2aQpktB2viCsKFHeQbgS5j9X1paMSJtQK/9U1fNKy253VlH5Ha9Zl9nrJg==; 24:Yvnd/43l1PQ/h1k65jWib9d1KJcT1B2q+8BKSZA515bk8D5rJo9BJ7q1kQNdIXtnpgsq6/wvJdZn30LOACnyf5NXbLC3ou0P10eylxvLD/0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: bluetreble.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2016 01:19:39.2110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0677 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --------------040801020207020308050803 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 1/2/16 5:57 PM, Jim Nasby wrote: > Attached patch clarifies that %-related error messages with hints as > well as (IMHO) improving the clarity of the message: Sorry, forgot to update regression tests. New patch attached. -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com --------------040801020207020308050803 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="patch.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch.diff" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC92YXJsZW5hLmMg Yi9zcmMvYmFja2VuZC91dGlscy9hZHQvdmFybGVuYS5jCmluZGV4IDg2ODMx ODguLjk1ODNlZDAgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2Fk dC92YXJsZW5hLmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3Zhcmxl bmEuYwpAQCAtNDY0Nyw3ICs0NjQ3LDggQEAgdGV4dF9yZXZlcnNlKFBHX0ZV TkNUSU9OX0FSR1MpCiAJCWlmICgrKyhwdHIpID49IChlbmRfcHRyKSkgXAog CQkJZXJlcG9ydChFUlJPUiwgXAogCQkJCQkoZXJyY29kZShFUlJDT0RFX0lO VkFMSURfUEFSQU1FVEVSX1ZBTFVFKSwgXAotCQkJCQkgZXJybXNnKCJ1bnRl cm1pbmF0ZWQgZm9ybWF0IHNwZWNpZmllciIpKSk7IFwKKwkJCQkJIGVycm1z ZygidW50ZXJtaW5hdGVkIGZvcm1hdCgpIHR5cGUgc3BlY2lmaWVyIiksIFwK KwkJCQkJIGVycmhpbnQoIkZvciBhIHNpbmdsZSBcIiUlXCIgdXNlIFwiJSUl JVwiLiIpKSk7IFwKIAl9IHdoaWxlICgwKQogCiAvKgpAQCAtNDc3OSw4ICs0 NzgwLDkgQEAgdGV4dF9mb3JtYXQoUEdfRlVOQ1RJT05fQVJHUykKIAkJaWYg KHN0cmNocigic0lMIiwgKmNwKSA9PSBOVUxMKQogCQkJZXJlcG9ydChFUlJP UiwKIAkJCQkJKGVycmNvZGUoRVJSQ09ERV9JTlZBTElEX1BBUkFNRVRFUl9W QUxVRSksCi0JCQkJCSBlcnJtc2coInVucmVjb2duaXplZCBjb252ZXJzaW9u IHR5cGUgc3BlY2lmaWVyIFwiJWNcIiIsCi0JCQkJCQkJKmNwKSkpOworCQkJ CQkgZXJybXNnKCJ1bnJlY29nbml6ZWQgZm9ybWF0KCkgdHlwZSBzcGVjaWZp ZXIgXCIlY1wiIiwKKwkJCQkJCQkqY3ApLAorCQkJCQkgZXJyaGludCgiRm9y IGEgc2luZ2xlIFwiJSVcIiB1c2UgXCIlJSUlXCIuIikpKTsKIAogCQkvKiBJ ZiBpbmRpcmVjdCB3aWR0aCB3YXMgc3BlY2lmaWVkLCBnZXQgaXRzIHZhbHVl ICovCiAJCWlmICh3aWR0aHBvcyA+PSAwKQpAQCAtNDc5MSw3ICs0NzkzLDcg QEAgdGV4dF9mb3JtYXQoUEdfRlVOQ1RJT05fQVJHUykKIAkJCWlmIChhcmcg Pj0gbmFyZ3MpCiAJCQkJZXJlcG9ydChFUlJPUiwKIAkJCQkJCShlcnJjb2Rl KEVSUkNPREVfSU5WQUxJRF9QQVJBTUVURVJfVkFMVUUpLAotCQkJCQkJIGVy cm1zZygidG9vIGZldyBhcmd1bWVudHMgZm9yIGZvcm1hdCIpKSk7CisJCQkJ CQkgZXJybXNnKCJ0b28gZmV3IGFyZ3VtZW50cyBmb3IgZm9ybWF0KCkiKSkp OwogCiAJCQkvKiBHZXQgdGhlIHZhbHVlIGFuZCB0eXBlIG9mIHRoZSBzZWxl Y3RlZCBhcmd1bWVudCAqLwogCQkJaWYgKCFmdW5jdmFyaWFkaWMpCkBAIC00 ODk5LDggKzQ5MDEsOSBAQCB0ZXh0X2Zvcm1hdChQR19GVU5DVElPTl9BUkdT KQogCQkJCS8qIHNob3VsZCBub3QgZ2V0IGhlcmUsIGJlY2F1c2Ugb2YgcHJl dmlvdXMgY2hlY2sgKi8KIAkJCQllcmVwb3J0KEVSUk9SLAogCQkJCQkJKGVy cmNvZGUoRVJSQ09ERV9JTlZBTElEX1BBUkFNRVRFUl9WQUxVRSksCi0JCQkJ CSAgZXJybXNnKCJ1bnJlY29nbml6ZWQgY29udmVyc2lvbiB0eXBlIHNwZWNp ZmllciBcIiVjXCIiLAotCQkJCQkJCSAqY3ApKSk7CisJCQkJCSAgZXJybXNn KCJ1bnJlY29nbml6ZWQgZm9ybWF0KCkgdHlwZSBzcGVjaWZpZXIgXCIlY1wi IiwKKwkJCQkJCQkgKmNwKSwKKwkJCQkJICBlcnJoaW50KCJGb3IgYSBzaW5n bGUgXCIlJVwiIHVzZSBcIiUlJSVcIi4iKSkpOwogCQkJCWJyZWFrOwogCQl9 CiAJfQpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC90 ZXh0Lm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvdGV4dC5vdXQK aW5kZXggMTU4NzA0Ni4uYTc0YjljZSAxMDA2NDQKLS0tIGEvc3JjL3Rlc3Qv cmVncmVzcy9leHBlY3RlZC90ZXh0Lm91dAorKysgYi9zcmMvdGVzdC9yZWdy ZXNzL2V4cGVjdGVkL3RleHQub3V0CkBAIC0yMTEsNyArMjExLDggQEAgRVJS T1I6ICB0b28gZmV3IGFyZ3VtZW50cyBmb3IgZm9ybWF0CiBzZWxlY3QgZm9y bWF0KCdIZWxsbyAlcycpOwogRVJST1I6ICB0b28gZmV3IGFyZ3VtZW50cyBm b3IgZm9ybWF0CiBzZWxlY3QgZm9ybWF0KCdIZWxsbyAleCcsIDIwKTsKLUVS Uk9SOiAgdW5yZWNvZ25pemVkIGNvbnZlcnNpb24gdHlwZSBzcGVjaWZpZXIg IngiCitFUlJPUjogIHVucmVjb2duaXplZCBmb3JtYXQoKSB0eXBlIHNwZWNp ZmllciAieCIKK0hJTlQ6ICBGb3IgYSBzaW5nbGUgIiUiIHVzZSAiJSUiLgog LS0gY2hlY2sgbGl0ZXJhbCBhbmQgc3FsIGlkZW50aWZpZXJzCiBzZWxlY3Qg Zm9ybWF0KCdJTlNFUlQgSU5UTyAlSSBWQUxVRVMoJUwsJUwpJywgJ215dGFi JywgMTAsICdIZWxsbycpOwogICAgICAgICAgICAgICAgICBmb3JtYXQgICAg ICAgICAgICAgICAgIApAQCAtMjYzLDkgKzI2NCwxMSBAQCBFUlJPUjogIGZv cm1hdCBzcGVjaWZpZXMgYXJndW1lbnQgMCwgYnV0IGFyZ3VtZW50cyBhcmUg bnVtYmVyZWQgZnJvbSAxCiBzZWxlY3QgZm9ybWF0KCclKjAkcycsICdIZWxs bycpOwogRVJST1I6ICBmb3JtYXQgc3BlY2lmaWVzIGFyZ3VtZW50IDAsIGJ1 dCBhcmd1bWVudHMgYXJlIG51bWJlcmVkIGZyb20gMQogc2VsZWN0IGZvcm1h dCgnJTEkJywgMSk7Ci1FUlJPUjogIHVudGVybWluYXRlZCBmb3JtYXQgc3Bl Y2lmaWVyCitFUlJPUjogIHVudGVybWluYXRlZCBmb3JtYXQoKSB0eXBlIHNw ZWNpZmllcgorSElOVDogIEZvciBhIHNpbmdsZSAiJSIgdXNlICIlJSIuCiBz ZWxlY3QgZm9ybWF0KCclMSQxJywgMSk7Ci1FUlJPUjogIHVudGVybWluYXRl ZCBmb3JtYXQgc3BlY2lmaWVyCitFUlJPUjogIHVudGVybWluYXRlZCBmb3Jt YXQoKSB0eXBlIHNwZWNpZmllcgorSElOVDogIEZvciBhIHNpbmdsZSAiJSIg dXNlICIlJSIuCiAtLSBjaGVjayBtaXggb2YgcG9zaXRpb25hbCBhbmQgb3Jk ZXJlZCBwbGFjZWhvbGRlcnMKIHNlbGVjdCBmb3JtYXQoJ0hlbGxvICVzICUx JHMgJXMnLCAnV29ybGQnLCAnSGVsbG8gYWdhaW4nKTsKICAgICAgICAgICAg IGZvcm1hdCAgICAgICAgICAgICAK --------------040801020207020308050803 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------040801020207020308050803--