Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aFr3T-0004mt-V5 for pgsql-hackers@arkaria.postgresql.org; Sun, 03 Jan 2016 22:23:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aFr3T-0000Ij-44 for pgsql-hackers@arkaria.postgresql.org; Sun, 03 Jan 2016 22:23:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aFr3Q-0000HI-9C for pgsql-hackers@postgresql.org; Sun, 03 Jan 2016 22:23:12 +0000 Received: from mail-bl2on0073.outbound.protection.outlook.com ([65.55.169.73] helo=na01-bl2-obe.outbound.protection.outlook.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aFr3I-0001TE-9O for pgsql-hackers@postgresql.org; Sun, 03 Jan 2016 22:23:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=BlueTreble.onmicrosoft.com; s=selector1-bluetreble-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AWt1AJuibi0+OhYJ9Tj7XJXRc5EvFBR/7sVcGPPBul0=; b=PlN/uJS28rAY2HdKD6322UuKpPam08iLhr1+2hP1rpX5RhDfHMpm+rhyuyhWbODuCZ2gAIMb1C8awCNds3saRMJK+5ASU4MWDqRKNFUhVGIz3+Pe36Fv1LpVbKZg8pZmYsMPR9EOW2Tn0To4c28pf/KFdDhKg4JGGwlo6P1iYwg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jim.Nasby@bluetreble.com; Received: from decina.local (70.113.16.71) by BLUPR11MB0676.namprd11.prod.outlook.com (10.163.216.146) with Microsoft SMTP Server (TLS) id 15.1.361.13; Sun, 3 Jan 2016 22:22:59 +0000 To: Pg Hackers From: Jim Nasby Subject: Very confusing installcheck behavior with PGXS Message-ID: <56899F36.9000607@BlueTreble.com> Date: Sun, 3 Jan 2016 16:22:46 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [70.113.16.71] X-ClientProxiedBy: BY1PR14CA0017.namprd14.prod.outlook.com (25.161.91.27) To BLUPR11MB0676.namprd11.prod.outlook.com (25.163.216.146) X-Microsoft-Exchange-Diagnostics: 1; BLUPR11MB0676; 2:y6QW3Er7OKNp28Hg1Vlozp1+ndQIXcKcqXvXeGEHhdmgAf/vkbU5bbcpDejhFWHpr/WocgLOpnG9mEWDmhZZ3AeBMv3GWnNejbatYfppR++O0deRdydX80OwPfUM0fgAsKACPoC8Wi8V9E8Mp1x7uw==; 3:sk3e7x24Inopa2gCz6MqpbLSWBpkDUoKPSnlo0qHaOxVeimWNAD/mZFzV2tHUQbxNasZi+2k6OVczoeX/1agBjxGocNueQWLFT7zkgrkkauL9lS/2ZiqhKyyXWy8Q0G0; 25:fxAz7D6Okey3cHRsm4m7Rx3g9D8EYqrgq6eVUDng+WcrJhHM5A2Qtd01xtfeMjgc8oagxEJmh4H8ksHbCZoy9Lr5jSfrssW444K5qbUnj+T1kujjxL6Y0ho7QBvs2Fest0SBy2bemaok5uiYXjidPKzc9/dOx2ZLsQO5NaPEVFrGUsrltcmnw1g+EIDAxzG7Se874r7pPPSmJdOWS2DIp8EbEopKCaIslOyUOvsWVHenBf8CIuy3abClR/f8h6tGLOgcuhrCy23IwgOxcPJY5g==; 20:vYW4P2g/ybwYGKyqy2M0q/4BYn2RQGPJ5CLa6zO9j0KdspTth74JFuOJTxFKFKjsVsFEi6h9T8Q30qFJoMvhYD0FphJ1a8SbVCMflnv7nE5fyu8hIHHa416gvqc25jcqJINvX5n2gmn8txBYy32u53JRvNDqbUogsWNwvLN5FDw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR11MB0676; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR11MB0676; BCL:0; PCL:0; RULEID:; SRVR:BLUPR11MB0676; X-Microsoft-Exchange-Diagnostics: 1; BLUPR11MB0676; 4:4094Er/uku+8OkwjPhBLx+1bPlh3pVUKLarjMm4hrq7/g3/NACOdOGhkuJuWyPzOTu+o6hoCf7s5YdtO6rSPsQeDCWiCK0GrGAmv9FvDxcLcqL1MQuyf12hejsOj8o6fo0q133ndTOL5JbhPTKcn9QErbW35shkYHt70rEVdsiBPo7/XiRXhUSHyXQrLKL97GohgrrF516SVFZOFglm/etz2w86ghFlfVeUP/KDpLEueOuhusbyBY33lYtGYJuswpoXhIUXM5H/084ol4twYQCv6qxQYLZQDQGgVuDSp01cpbJDgVuUiKjjxo0BwyylJPqckY3FNvKpXerygf1ZFlNfv+0fAADi2bmFjLiUOUehm2Av3dWeQkvS6B9Zb8Yx9 X-Forefront-PRVS: 0810818DA0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(189002)(199003)(101416001)(229853001)(65806001)(47776003)(106356001)(50986999)(5001960100002)(33656002)(42186005)(107886002)(83506001)(50466002)(92566002)(65956001)(66066001)(87976001)(110136002)(4001350100001)(19580405001)(97736004)(450100001)(105586002)(230700001)(122386002)(36756003)(86362001)(189998001)(64126003)(54356999)(80316001)(19580395003)(15975445007)(77096005)(23676002)(6116002)(5004730100002)(3846002)(586003)(40100003)(65816999)(1096002)(87266999)(59896002)(81156007)(5008740100001)(99136001)(85282002)(336755003)(18886065003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR11MB0676; H:decina.local; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: bluetreble.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjExTUIwNjc2OzIzOlZFQWF4NVNTdjIrdGJhWTY5WDNXTDBLWTlz?= =?utf-8?B?VGFuTENQblFNc3N3Q3RzUHZTTElKQ0F5Uy9sa3Y3LzhBL3Z6bEdOdXhlWE1X?= =?utf-8?B?QzdmbHhOd01JakFxSHNTT2Rqck9TQVV1aDlXYTJkT05NN1NxMFFTUmIydzBp?= =?utf-8?B?dzkxUnU5NW9ya3lWLzBaMTlKQTIvamFKTjVFcEZRM3hCa203UlhTMktrQWlE?= =?utf-8?B?WFpuckRTQTdHVk1RZXNhejhWSVNiSTg3OEo2ZWFOSmgza2RXYzVzamswSWNv?= =?utf-8?B?azNSQVJrMURvc2dxRlFuOWxJRHJEN2dpUjhYQUVKSEgyNXp2UXNYSlZGMDJS?= =?utf-8?B?Q1NPcTlxVzJrNktGdkl6azV2akJ6bDd5cFIzV0tuR1krcHdLTVpXc0hha2ti?= =?utf-8?B?cTNOb0plNlBLZXcvbWhhempMNTBiMGdsY1REbXd4dFh2cWk0bTIreWp1cFNS?= =?utf-8?B?S3NNQ2xtanpkeFAybHFIcWpuOGFXSE9XcTFkZEhTRTRoR25qYU5wTWkvcjBp?= =?utf-8?B?RkM3cnRROXozdTU5ZW9CWjQwMkI4dUJxT0JaNmExbE5icDRjZHRDK3hoYXl1?= =?utf-8?B?aHd1QWRIamlTOHRneURTYldQbGJuVTJRR3VWMXpJQTJFcFF4bmxBRkVqUkxU?= =?utf-8?B?ODlUeDVJMWpvM0RzemVidVJac1BMTUp3YW8xbncyZzBIZUhOZlJDNjR5K2la?= =?utf-8?B?TjhDQmx2V3lpbUo3dmpWMmdibCs4QUlCV1dJWUpEQ1hIc0w0cmhKb1p3WlhI?= =?utf-8?B?U2R6c2diSzdQMGhJZ1M0ZjZPR2FBWlVzUXlKNVArTmFlcHp2bUxYKzNmOXlH?= =?utf-8?B?NmRMOVowSGdSeENhSU5XRUhpR0NzeEhhck9jYzhxVUxnbWp1SGtyQld2WW1N?= =?utf-8?B?akJkYVo2RGFxUGVyOVJFMEtWdnpkYVRnUm15bjMyRUd5NURub1FnV0hBWnE4?= =?utf-8?B?MG1aNWk5cWVyeUdOZ0U1SURVaGNnQitZSzBWeGRqNkJKZithSDZUTGZHcnRv?= =?utf-8?B?UlZBYmI5VmtzNUQzakhUWFZGYXZqc2dzQkpoN3M4b1FzalR2VzFxK3BKZURp?= =?utf-8?B?Q0lZV3VIQjFFb0JMcTA3R0RuR2dONWRuNVhyeE1UL2pFSXJGaUZDbkt2emw5?= =?utf-8?B?TnVBbHFKdkQyVmVMUXNqOGNUU25Vc3Yydkp4RHVoSk5xUkpmSDVXaTA1bllV?= =?utf-8?B?QnZDTEFFN3VlMThFRTN2RVZSWWV2cmdrd2JoQzB3WFI2Z25CeXpNYUcwODEy?= =?utf-8?B?WFVPa08vWngyNTFYZUlobkdpallMQVl2RklpaXpxSlRKcUNwaDlITXZMVEhp?= =?utf-8?B?WVBjUEdqb29VNjFNOFA4czc1dEsxYjBTbXEySWdNdWNkbytlb09wc2ZDMWhM?= =?utf-8?B?Qnc0cXhaOXhEcWNiWGJOVTlNYnZoaS8raCtNME5lOUozMU1IanIrMGtQWUpm?= =?utf-8?B?RC8yRjhTbjhENjVVMDFsWkR5enB2QnA2K1VQL0RRYnNDVzFSYzNmNEdSR2lZ?= =?utf-8?B?MDUzZDlPblBUK2lpaWV3eTU1Y29ONE1VVmhsRktpQWVqdWtZRXBQa25sUkRH?= =?utf-8?B?RVJURWVtOGh0UWpXQ2t2Vys1aE1iV1J2bEVyNDBmR0xMWUZ2S05nZXdIb3VS?= =?utf-8?B?d3VhdmhyZW1kbWpObHJpYUQ0UlR2anRDOTBxVytaRVI0a0EwM3paZ2FnRkNx?= =?utf-8?B?MnM1THBVS3VWYTVicDM0cXBVbWpadVB2cUNIRjA5bzU5TW0xUUNWT09aS1ZM?= =?utf-8?B?TG1Ia0IvbzdoZmhrNVJueG9oRGpnTTVucHhUR0xIMC9HTDlPeTB5ZEhDTDl3?= =?utf-8?Q?oWbtCN/LudlTs?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR11MB0676; 5:jD70K2W3wPx6Ot0FzsZcgkVZmdEZVWUh1yd8kWK7DNabm5vnjwAtRbj3piUB5/WBTTLp7TNbeVchlgDjMgN3Zsa+d1Ncx+i+Sp8oIFrIVdHH/JZqwOxhGLp2p2A2Zfd+asTe1sJWGN7gXSN8xvdUxg==; 24:HbFjzaGeJ7bF9t9CT7tuGloXcB/+hYe0drT3mwpsX58NL8Y5XkFCLKSCPUBsxz9yKwkwfNzvDSIVE/YHdCKHw1JxSlXWvuNovlP/b8uTcw0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: bluetreble.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2016 22:22:59.9052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR11MB0676 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org The rule that gets executed if you do `make installcheck` with something using PGXS is pgxs.mk: $(pg_regress_installcheck) $(REGRESS_OPTS) $(REGRESS) where $(pg_regress_installcheck) is set in Makefile.global.in to > pg_regress_installcheck = $(top_builddir)/src/test/regress/pg_regress --inputdir=$(srcdir) --bindir='$(bindir)' $(pg_regress_locale_flags) $(EXTRA_REGRESS_OPTS) The problem here is that in a PGXS make, srcdir is set to '.'[1], and --inputdir is specified a second time in REGRESS_OPTS. Normally that works OK (for some reason ignoring what's in ./sql), but if you happen to have a file in your test/sql directory that matches a file in ./sql, pg_regress runs the first file and not the second. Presumably that's exactly what you'd want in most of the tree, but it's definitely not what you want in an extension. Is the best way to fix this to add a pg_regress_installcheck_pgxs variable in Makefile.global.in and modify pgxs.mk accordingly? [1]: > decibel@decina:[16:18]~/git/trunklet (master=)$make print-pg_regress_installcheck print-REGRESS_OPTS print-REGRESS > pg_regress_installcheck = /Users/decibel/pgsql/9.4/i/lib/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --psqldir=/Users/decibel/pgsql/9.4/i/bin > REGRESS_OPTS = --inputdir=test --load-language=plpgsql --dbname=contrib_regression > REGRESS = all build -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers