Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aGC1c-0001y6-HY for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Jan 2016 20:46:44 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aGC1c-0004eF-3Y for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Jan 2016 20:46:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aGC1a-0004dI-UC for pgsql-hackers@postgresql.org; Mon, 04 Jan 2016 20:46:42 +0000 Received: from mail-bl2on0074.outbound.protection.outlook.com ([65.55.169.74] helo=na01-bl2-obe.outbound.protection.outlook.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aGC1W-0007MP-Fd for pgsql-hackers@postgresql.org; Mon, 04 Jan 2016 20:46:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=BlueTreble.onmicrosoft.com; s=selector1-bluetreble-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oHiQEwGoAeSqjNW2F+JmOrhsk8EG7EEAjSAsu7UMMsM=; b=l5rR1aqKnlqOD1iGZOLKGBlCdXU06jtQkJi7h050z8kFqVABI8d2zCz3SEUH0MPTkX8VxhO8186pxcKzBxS8Za6UbmZL0QYF53ZyvXIif1XJySUi6CDeNXJD6AFaKquMk0eqJTxP6DNND3jczvO+aCp73En0qrEyV5ZWF5lgC8k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jim.Nasby@bluetreble.com; Received: from decina.local (70.114.174.14) by CY1PR11MB0681.namprd11.prod.outlook.com (10.163.236.19) with Microsoft SMTP Server (TLS) id 15.1.361.13; Mon, 4 Jan 2016 20:46:32 +0000 To: Pg Hackers From: Jim Nasby Subject: Beginner hacker item: Fix to_reg*() input type Message-ID: <568ADA20.7090205@BlueTreble.com> Date: Mon, 4 Jan 2016 14:46:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [70.114.174.14] X-ClientProxiedBy: BY2PR1001CA0084.namprd10.prod.outlook.com (25.164.163.52) To CY1PR11MB0681.namprd11.prod.outlook.com (25.163.236.19) X-Microsoft-Exchange-Diagnostics: 1; CY1PR11MB0681; 2:5nWupAUAhAsSgydGOIUdjO0aBCKgUO03To5jal4ghzNSsAJdFyEbGipDAycWxV5ExtoGxjiBNKDhrC2faRs+eBF3e5Pfht6MtME66dY5zW/XSDQZ27s0VmdBj8jZRPazgADkwnUaaLbNitiYkkKwPQ==; 3:SQmhen/QJJ3+qzqH9WPoHNvEh+tW2zgwrS/N5GzII34JnGjCuqpLwhY3SEGeZre8UzlLhwZKy1/wi8HLphACsuyY5k7bufwu4oNeQTlvV6RxOlV1SfFLrNxvFW8CslRa; 25:yXa5LQoNZuXY9+4LZ32xV4HY8n6dZ9/foE+Nl+l4PcMfMB4v2BboCi1K2fxKQOhiBMmDhuLBL8Kq4BV3/sr0x+5NHFmKwmKLuQ6hd99g0GqZIRSZ9Hra2jqtkRPMEY50qalPGkaC0t4jBS4ooQbZdnnx8/if/T4ADwBktjr5r1hn9i42K/kpGOeF5SJB0xIkyyLpQNYptnRH4KR0LK0YiZ0XE1aD3dz2q7rdhFSg2oggkMklo5W5JQ2aKAcD29Q5; 20:7Kce0CmFTgEEM+cvIilTTH4CpAQJSeKzSdHIAuWuKtk167uYc7LFH+HOdV6D0Mb3iQH5YgjxdbHXK5YizNPt+0lIHEdvidPanRiLsJOjuyke2iHcNrQZoI3XEB5hFaEuprTzjLVHCUdFlg+uC0025JxVjIhj+WD0UMShcLZjgNk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR11MB0681; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046); SRVR:CY1PR11MB0681; BCL:0; PCL:0; RULEID:; SRVR:CY1PR11MB0681; X-Microsoft-Exchange-Diagnostics: 1; CY1PR11MB0681; 4:rOh3jpt5DjA9fQRru4GKuTnOylSONpJ9HppDJUSiQI+OVUrXCVLugh6os2t8X2EGeIMAbSUuUQRSVqXpmqH1bsWCiH2xQ3W2BYzh7I8lO5kyZZGbmbNTW6SxEvAeRy8MeINBuR53DwAsq5vjYMXOYwO1HtxCBV7u2ZwBIsUeHWH65h/HUSRxi+vtvdtf1ku+AQvyRuFzbnJ7y+RBgc7N2SI9M4W86cc7Ga/3F7cSnS5DIUhcGEUglawYT3q2iOlv4e2xYxw8D679FEB3bHPLUUDwIbcRFHjK9+qAT+aJnkZSE0BWXLEwF7sFTv5nLnk7zJlkIvaYHYSQTmuqEyIeWeceKFNq9qzKZcki1DeaO6EWWKp4i8rT6Tokc9mxIKPf X-Forefront-PRVS: 08118EFC2B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(199003)(189002)(101416001)(5001960100002)(92566002)(189998001)(19580395003)(81156007)(4001350100001)(87266999)(86362001)(64126003)(15975445007)(6116002)(107886002)(33656002)(80316001)(106356001)(87976001)(97736004)(105586002)(42186005)(450100001)(40100003)(5004730100002)(59896002)(5008740100001)(36756003)(3846002)(77096005)(19580405001)(47776003)(23676002)(1096002)(65816999)(50986999)(229853001)(83506001)(110136002)(65806001)(50466002)(122386002)(230700001)(586003)(66066001)(65956001)(54356999)(85282002)(336755003)(18886065003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR11MB0681; H:decina.local; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: bluetreble.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjExTUIwNjgxOzIzOmZXU2dXcTMvU1U1c3M2K3dKM3NNUzJ1Mmcr?= =?utf-8?B?TUIwY1FvL2M4SGwva1VEeXZYQ203RXdJd1BqU3RONEhSaDkxQmFiTCsvbmlP?= =?utf-8?B?QWJJdHFyWG8xVGVVbDB0ZG9ZRzB5Yzg5UHJtUit1citROW81MmdJQkFBV0Ra?= =?utf-8?B?Tkh6MHJhczJleDg3ZlV1YUNNR3czZERGZStmSnJLeVBHNGRuSXU2djNOS1pR?= =?utf-8?B?OUZ3d3l6S2JQSzM4a0lHbGVvLzBnZ0Y0bHNGbGN1VXJFTFVOVmlON0FtU3BP?= =?utf-8?B?ZXZWdGs0MkNOVVhWVjloNkpweUJuQXVJR09nKzU0dytEMUswKzZsekxtRTlB?= =?utf-8?B?SCtJZ29pbTk0UWdYczJPTjQzK0p6OEVlNjQwV2F4UFJ1ZXEreWdHRjUzbHRt?= =?utf-8?B?MExxRTRtR2IySzJCL3VaQXJQRm9SZGxvbjZMalREbFcrbVhxUW9xNjlIaFU0?= =?utf-8?B?ZkxaNVBVdjhUZmdLSm1ncWJXV0xNcUxZQysrVXo0UWdVVWhZeXNYK3A4UUZU?= =?utf-8?B?aHZIKzYxSldPVlB0V0NEOW5yZGVzU3ZvdzlFVStrSk0yektwNmQyd2h1UmNt?= =?utf-8?B?aHIwN2xMck5Zc3dsT2lZOUpvbmRZMmxvNDl6NXdqbmhkRlN1NGduQnlxM2RR?= =?utf-8?B?dUk2blc3YW1uNXhJNEZGNEUvMmJHeithcmZnSmlRWGNuRS9jbkVTM1JlNDNB?= =?utf-8?B?TWR0MkFIQ0JBZ2xHZ0h2YnFUUGNaRmlKS1d3M0t1SnhWV2IzVTFIRDFDUzA2?= =?utf-8?B?NXpJMzdqUEhXaVlrN0tuaFZkdzBCU1poZnJvQTRrRTM1Q3lPcXltcEN0dXYv?= =?utf-8?B?b3RvQVJ5VWFVWTBpZWhVdG5ZT0hLTWFHYU8xN3lDMVdvR1VUQnhkci9lbCtM?= =?utf-8?B?Q0FGbDB3Tms0akxaSkR5czRUYzZPbWU3NlV2bE8xbVIzSUZJOGlnRW9lT2JL?= =?utf-8?B?U0ZCYWE0c0FmWUNlZmF4Y2hFTUV4NkhQMVBZdCtnc0o1Vkl5dWgreDY0Ti9D?= =?utf-8?B?RzJmeHRzUFdjUHJUZGw1TWFYbFJFa1VpRTRkeFBtVmxndU1HbXdPMTQ5MExW?= =?utf-8?B?R0V3RnV0Z3Joc0oydVY2T1l5WWVEWmsrR1JpSDRmWUU5eVZ6ZkZYOVFnYnJR?= =?utf-8?B?SjA4NEpwK3FXZ29oZlBGVjlqYXVtd3ZYa2hGdis4YmhlbUdFRHNkc2pITFM1?= =?utf-8?B?a2ZkM0MvVDhsVVc4U1N6YWtaQ3lQSGZobkF4WGRyN01PclV5bEx3cnpjK29a?= =?utf-8?B?aExsVmg3T0tpeFhmMGt0SC94bThkYzVOcjdRNVByZDM5TkZON3B4dHMrVnNh?= =?utf-8?B?Mnl1aFo3cFNKUG5KMGk0eVBDVzNjNjZYbDgwMFhMVWNKSHQvWEJwVG5kbXNx?= =?utf-8?B?TmhJS2UvTkd4ZVIxN2U5d3VxTUljdWpUQkZYNlg0dG16Tk1ZV1NLMGZKNEFN?= =?utf-8?B?R3lsaVR5UlkrUDV4akVwR2JmLzJWTlF5QldkaE1QLy9wYy9lay9xV3B4ZVlD?= =?utf-8?B?elpWQ2crYzZXNXR2Y1dPTVJGRU9RZVptd01zZEFrUlc3eXBmNEIyZTUzamQx?= =?utf-8?B?L3N3aVQ4bUdSRjNXZkZJSGVoQnB3andJYzZFZXBqbzlGQ2NXL0xYSFBHVkZk?= =?utf-8?B?aGRlZk9BV3JQbkY0dnlTSE5GMHhna0ZEWTMraWdCOENhS0dLd0VmN3pkODdX?= =?utf-8?B?MEl0Vm91cU9DUUo0UDNEMWtibzFvSDFEREhxTDhpVFpqbkhRa2c1bXdTTVZX?= =?utf-8?Q?J7VPqbB8V9PnO0NVe4gPO/QZura8tPEMi/m5M=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR11MB0681; 5:UW1tEH/t8Od1AYlxtjHeDS+EJwLAZX1g5ObQGVn2WeEK01gtp4SLSGd4veMU/91gGF0mvpGEU9liQIOYHEIqJ14c5JdtNacM5AxHryaOPFfIkqc5V3bO1MJytEeg1giXhCfD9NJysS3gNQ17MlBIEA==; 24:6NQR9HQZX0+oRHmfdvh/t3nZ7rUBNTB9IGIrHP9/0TTWv9DBtQqSLCfZmUMT/RfToF9sUADfzoam5b7Ub1Yc8j7KgXZ8u+z0vqrci/iAk6M= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: bluetreble.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2016 20:46:32.6121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR11MB0681 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org All the to_reg* functions in src/backend/utils/adt/regproc.c currently accept a cstring. Per [1], they should accept text. This should be a fairly simple change to make: - Modify the functions in regproc.c. Take a look at how other text input functions work to see what needs to happen here (you'll want to use text_to_cstring() as part of that.) - Modify the appropriate entries in src/include/catalog/pg_proc.h [1] http://www.postgresql.org/message-id/29618.1451882238@sss.pgh.pa.us. Note that I mistakenly referred to reg*in functions in that email; it's the to_reg* functions that need to change. -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers