Subject: Re: Making tab-complete.c easier to maintain
To: Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
References: 
 <CAB7nPqS=UHm2QyJtx+kyyHb4WH09vK3NVUqJVFBotQAQx5hD4g@mail.gmail.com>
 <CAEepm=2vMAESiiind-jbQK-sAibLr1440E8pj_KmWYO8XBtiRA@mail.gmail.com>
 <1851.1450471370@sss.pgh.pa.us>
 <CAB7nPqS0-TjcwUWM4R+-77aCrAz9B6a+S_d973CeJvfLm7r-Tg@mail.gmail.com>
 <21460.1450560248@sss.pgh.pa.us>
 <CAB7nPqQpDTQHn3s20-xLP93Cs3LBpCtedrSO1yN8kRoMhSg7eg@mail.gmail.com>
 <CAB7nPqQbBxBWGuVZ1a4ZZDic=D3NJg=gpo18UtND0_aCV0eiRw@mail.gmail.com>
 <CAEepm=34Ba7rDa-mASkxmaD87aW21juALF58B6MRwKc54JYFmA@mail.gmail.com>
 <CAB7nPqQGCXGjrrDQo2ZB9FhvzrZSZk0NoFvhrsKh8-gwuU4wmQ@mail.gmail.com>
 <CAB7nPqTe_HvKQY31W5bNyyTHRn23PPQ-7hwJqNKL5LExT4D4oQ@mail.gmail.com>
 <20151230142118.GV58441@alvherre.pgsql>
 <CAB7nPqSKK1DinEALv-00hhRJ740JhWVvHoanXzRsQpmJen=8BA@mail.gmail.com>
 <CAB7nPqSCekNhu67cM3GYqnrKyvM3SdXr97URbeA3BY7XoKwWJw@mail.gmail.com>
 <17239.1451956418@sss.pgh.pa.us> <28999.1452013388@sss.pgh.pa.us>
 <CAB7nPqSLWH7Myit78SX=BQSg1mQ=KQdZ-53pieYgqrYjkKuQgw@mail.gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 Thomas Munro <thomas.munro@enterprisedb.com>,
 Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
 Jeff Janes <jeff.janes@gmail.com>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
From: Andreas Karlsson <andreas@proxel.se>
Message-ID: <568CD784.20804@proxel.se>
Date: Wed, 6 Jan 2016 09:59:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.4.0
MIME-Version: 1.0
In-Reply-To: 
 <CAB7nPqSLWH7Myit78SX=BQSg1mQ=KQdZ-53pieYgqrYjkKuQgw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 01/06/2016 01:13 AM, Michael Paquier wrote:
> On Wed, Jan 6, 2016 at 2:03 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I've pushed the second patch now.  I made a few adjustments --- notably,
>> I didn't like the way you'd implemented '*' wildcards, because they
>> wouldn't have behaved very sanely in combination with '|'.  The case
>> doesn't come up in the current set of patterns, but we'll likely want it
>> sometime.
>
> Thanks! Let's consider this project as done then. That was a long way to it...

Thanks to everyone involved in cleaning this up, it is much easier to 
add tab completions now.

Andreas


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers