Subject: Re: GIN pending list clean up exposure to SQL
To: Jeff Janes <jeff.janes@gmail.com>,
 Jaime Casanova <jaime.casanova@2ndquadrant.com>
References: 
 <CAMkU=1x8zFkpfnozXyt40zmR3Ub_kHu58LtRmwHUKRgQss7=iQ@mail.gmail.com>
 <CAJGNTeNVBMDzxwi=QaJWbeVequf1oENF9GbFaRMfny9H6ic_Ng@mail.gmail.com>
 <CAMkU=1xdv5n8w2-n4j_ysXy6eRd69XhWiGrdxQbqDjWEpBavww@mail.gmail.com>
 <CAMkU=1wEzVkxDJSQe5gbwb7AQ7zMi3D7mr-XMQBoyPzUnzpSpQ@mail.gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Julien Rouhaud <julien.rouhaud@dalibo.com>
Message-ID: <56924D75.7060801@dalibo.com>
Date: Sun, 10 Jan 2016 13:24:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: 
 <CAMkU=1wEzVkxDJSQe5gbwb7AQ7zMi3D7mr-XMQBoyPzUnzpSpQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 29/12/2015 00:30, Jeff Janes wrote:
> On Wed, Nov 25, 2015 at 9:29 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
>>
>> I'll prepare a patch for core for the January commitfest, and see if
>> it flies.  If not, there is always the extension to fall back to.
> 
> Here is an updated patch.  I've added type and permission checks,
> docs, and some regression tests.
> 

I just reviewed it. Patch applies cleanly, everything works as intended,
including regression tests.

I think the function should be declared as strict.

Also, there are some trailing whitespaces in the documentation diff.

Regards.

> Cheers,
> 
> Jeff
> 
> 
> 
> 


-- 
Julien Rouhaud
http://dalibo.com - http://dalibo.org


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers