agora inbox for [email protected]
help / color / mirror / Atom feedFrom: Julien Rouhaud <[email protected]>
To: Jeff Janes <[email protected]>
Cc: Jaime Casanova <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: GIN pending list clean up exposure to SQL
Date: Fri, 15 Jan 2016 23:42:21 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAMkU=1w0z86n=+N1yFfKx4-wrO1m6M9XvEFBhV6TQmV4sK1waw@mail.gmail.com>
References: <CAMkU=1x8zFkpfnozXyt40zmR3Ub_kHu58LtRmwHUKRgQss7=iQ@mail.gmail.com>
<CAJGNTeNVBMDzxwi=QaJWbeVequf1oENF9GbFaRMfny9H6ic_Ng@mail.gmail.com>
<CAMkU=1xdv5n8w2-n4j_ysXy6eRd69XhWiGrdxQbqDjWEpBavww@mail.gmail.com>
<CAMkU=1wEzVkxDJSQe5gbwb7AQ7zMi3D7mr-XMQBoyPzUnzpSpQ@mail.gmail.com>
<[email protected]>
<CAMkU=1w0z86n=+N1yFfKx4-wrO1m6M9XvEFBhV6TQmV4sK1waw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-hackers>
On 15/01/2016 22:59, Jeff Janes wrote:
> On Sun, Jan 10, 2016 at 4:24 AM, Julien Rouhaud
> <[email protected]> wrote:
>> On 29/12/2015 00:30, Jeff Janes wrote:
>>> On Wed, Nov 25, 2015 at 9:29 AM, Jeff Janes <[email protected]> wrote:
>>>>
>>>> I'll prepare a patch for core for the January commitfest, and see if
>>>> it flies. If not, there is always the extension to fall back to.
>>>
>>> Here is an updated patch. I've added type and permission checks,
>>> docs, and some regression tests.
>>>
>>
>> I just reviewed it. Patch applies cleanly, everything works as intended,
>> including regression tests.
>>
>> I think the function should be declared as strict.
>
> OK. I see that brin_summarize_new_values, which I modeled this on,
> was recently changed to be strict. So I've changed this the same way.
>
>>
>> Also, there are some trailing whitespaces in the documentation diff.
>
> Fixed.
Thanks!
> I also added the DESC to the pg_proc entry, which I somehow
> missed before.
>
Good catch, I also missed it.
All looks fine to me, I flag it as ready for committer.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (25+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: GIN pending list clean up exposure to SQL
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox