Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aLZu7-0005ZJ-CV for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jan 2016 17:17:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aLZu6-0005V9-Ve for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jan 2016 17:17:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aLZsm-000396-8h for pgsql-hackers@postgresql.org; Tue, 19 Jan 2016 17:15:52 +0000 Received: from newmail.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by magus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1aLZsi-0002Ot-Ov for pgsql-hackers@postgresql.org; Tue, 19 Jan 2016 17:15:51 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id EAE4621C59F1 for ; Tue, 19 Jan 2016 20:15:47 +0300 (MSK) Received: from mail.postgrespro.ru ([127.0.0.1]) by localhost (mail.postgrespro.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DlBzj5iUoXLY for ; Tue, 19 Jan 2016 20:15:46 +0300 (MSK) Received: from [192.168.27.79] (unknown [192.168.27.1]) by mail.postgrespro.ru (Postfix) with ESMTPSA id 8E37121C59F0 for ; Tue, 19 Jan 2016 20:15:46 +0300 (MSK) Subject: Re: WIP: Covering + unique indexes. To: pgsql-hackers@postgresql.org References: <56167F09.3090101@postgrespro.ru> <56168952.4010101@postgrespro.ru> <5617DAA3.6080408@postgrespro.ru> <565D9859.3040405@postgrespro.ru> <569530FC.2010900@postgrespro.ru> From: Anastasia Lubennikova Message-ID: <569E6F42.9040601@postgrespro.ru> Date: Tue, 19 Jan 2016 20:15:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org 12.01.2016 20:47, Jeff Janes: > It looks like the "covering" patch, with or without the "omit_opclass" > patch, does not support expressions as included columns: > > create table foobar (x text, y xml); > create index on foobar (x) including (md5(x)); > ERROR: unrecognized node type: 904 > create index on foobar (x) including ((y::text)); > ERROR: unrecognized node type: 911 > > I think we would probably want it to work with those (or at least to > throw a better error message). Thank you for the notice. I couldn't fix it quickly and added a stub in the latest patch. But I'll try to fix it and add expressions support a bit later. -- Anastasia Lubennikova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers