Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aYz4T-0001JO-PD for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Feb 2016 16:47:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aYz4T-0004Jd-7y for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Feb 2016 16:47:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aYz37-0002pm-VI for pgsql-hackers@postgresql.org; Thu, 25 Feb 2016 16:45:58 +0000 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aYz2w-0003as-VZ for pgsql-hackers@postgresql.org; Thu, 25 Feb 2016 16:45:57 +0000 Received: by mail-lb0-x234.google.com with SMTP id x1so32220733lbj.3 for ; Thu, 25 Feb 2016 08:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:mime-version:in-reply-to :content-type; bh=II/ar3ciQz98af2puLTQP0POVrKLE3//CaMM1eaNjWc=; b=yqcWs4dLH+jPTaIdBgf4FgHFPqFBX1pR30fPe6MYvjhvEXALFmhXeTDF8+38AwFiJM t8IA7BtSY/NPcCyiO/eTv+qvZAisncSL8/NDCx2BW9xbeGdtfAqFsodBPxdpriN5ZZQz Uq971aQxEQumOGMJheuhJlIWY6Wq3y6WfcDRNZSri96LGVEtwTISNBsOOTb5zAhwrkiu 7rjpVOpmJB0xFf7FIcCxH59Cg34W+iF2vy86F2b15zc12j7NDLOvxhNpec1nPF0ItOc3 7qsjkwHJiTkpeWl1LbXANfPPs4tGn/TcbGuy7YYZmS3kADSGlUt95wBPETb0DGj+m81K +/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type; bh=II/ar3ciQz98af2puLTQP0POVrKLE3//CaMM1eaNjWc=; b=RRTxvv09FNOfn5/cV8VMgL7+YJdJp8TW2oSPQzcB/wYYQJlzSw0c7DNnoF+5goP7Xc APQDQDhl5zxJegIg0R2WLEl5+w6DfPYZ995FJC7Hx0q0wHTgWqyXzfJ6/xKoClTGIxMe 7RlNRrXNNVrljY1tdTJycv8inGwl8xtSAHJoUTCAgX3Sf9/GZ+l4ERjo6bVcYZfbRd6J ehvRY0UWsUqmGFFluYCHAsmH9QprZUXgv5B4+NigkcHa245SY1ryfhpNXdb6PUt3IYKq 8AH4UJxHYR+1dJp/ZOpo8jTIt7KKpP3C3f7KPMKoJAM0h9mQgRmCtoDsPD7JxsJSQ8+F pB7Q== X-Gm-Message-State: AG10YOTHCZfJGXjwZp8BBteQApI7q2BtqirKBGhJ6RmaVZWB91gvX3IpfYV0GiFHKW0eZw== X-Received: by 10.112.137.41 with SMTP id qf9mr17064692lbb.140.1456418746329; Thu, 25 Feb 2016 08:45:46 -0800 (PST) Received: from [192.168.0.50] ([185.5.219.249]) by smtp.googlemail.com with ESMTPSA id u201sm1270781lfd.13.2016.02.25.08.45.45 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 25 Feb 2016 08:45:45 -0800 (PST) Subject: Re: Request for Code Review: BPGSQL To: Rich Jones , pgsql-hackers@postgresql.org References: <56BC8C11.1000505@gmail.com> From: Jacek Wielemborek Message-ID: <56CF2FB8.4080608@gmail.com> Date: Thu, 25 Feb 2016 17:45:44 +0100 MIME-Version: 1.0 In-Reply-To: <56BC8C11.1000505@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5MSbBXvVBm4rmNcRDmm1gaTwvpDAU3xrr" X-Pg-Spam-Score: -2.0 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5MSbBXvVBm4rmNcRDmm1gaTwvpDAU3xrr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable W dniu 11.02.2016 o 14:26, Jacek Wielemborek pisze: > W dniu 11.02.2016 o 14:06, Rich Jones pisze: >> Hello, team! >> >> I am writing on behalf of the BPGSQL Project [1] to request a code aud= it >> from a core PGSQL team member. >> >> The current maintainer is worried about the security of the code, and = is >> considering closing the project unless it can be properly reviewed [2]= =2E As >> a project living downstream[3] of that client library, I'd obviously m= uch >> rather see that project get reviewed rather than see it die. >> >> Would anybody here be so kind as to volunteer to give BPGSQL a code re= view >> from an upstream developer's perspective? It would have a lot of value= >> downstream users who want to use Postgres on Amazon RDS for serverless= >> applications, and I'm sure in plenty of other places. >> >> Thanks very much!, >> Rich Jones >> >> [1] https://github.com/d33tah/bpgsql >> [2] https://github.com/d33tah/bpgsql/issues/7 >> [3] https://github.com/Miserlou/django-zappa/issues/3 >> >=20 > Hello, >=20 > Thanks Rich, I second the request for a code review. >=20 > I felt I'd add that this is a 1500-line pure-Python PostgreSQL client > module that I inherited after Barry Pederson. After I realized how > execute() is implemented, I have my worries and I'd rather not risk > making my users vulnerable. >=20 > I'd be really grateful if somebody who knows a bit of Python and the > guts of PostgreSQL could speak up on this one. >=20 > Cheers, > d33tah >=20 Hello, I just unsubscribed from the mailing list so please CC next time you post a reply to this thread. Cheers, d33tah --5MSbBXvVBm4rmNcRDmm1gaTwvpDAU3xrr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWzy+4AAoJEGlViymZXJRvWK8P/Rq50U5bQeDp1ETqHI6JfSCj MX4euaZP+OY9+0DkScJnzpy3AfpTxGw2aYNk4kE14ic7fT0PtNEoQGmvwLHfoimK uGTfK1v68LD+4Nr4dHqFU/33exXiojT8ClTrvjeYku4JnDUkEDVMPDHqP6sQkRb0 doEZA0W6vhsj00k9+7oCPvL5skYIOg4duaV1CeuiBOi5KH42XAmdcFdj+Z77qHnR nI/vQ58chjqN8AhWqSVK/zzDIWYa7iMvHtGxtCvBMnpQutCD2JTwtmRFaP3wpGs0 lVkApbwrTO4GOyT58K8vrqC5ojRGLgh9lDfCP+/3TKTtNXtc+EUfCruEhDG1vBVD 5t1YMYzMaCqYODZaLNu7J+WROFFdItn3G8Ltx9u9B7mOMLpMexqwGyHs+7QxJb5Q KThWhOGofK2wySsp1GgIgmxUEvU1iQd20p9V2x6lg4PRYp07o8eKPAqIquzNMW90 jYAyTIB30brVYE1E5ny2/CmYLiGMncHZF50Z9t0ZfGdzSzD1GthIhVJa3mDvWZxh bbAKVHz4HPqojBMKMjvyzWia3pbGJSdbA7kUQp92Ps6NrF/7uwWv9GHGo/veN+IW tvfLEwcmLA67kTJ+P7gTwEFmfOFNZoXkp2YF940nNSYSsVuY9yn33XDFO7YcpfWJ pxKY8ecRJoqyv5jOc3U/ =y0wS -----END PGP SIGNATURE----- --5MSbBXvVBm4rmNcRDmm1gaTwvpDAU3xrr--