Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1afS8U-0002cS-JM for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Mar 2016 13:02:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1afS8U-0006g7-65 for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Mar 2016 13:02:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1afS8T-0006g0-LD for pgsql-hackers@postgresql.org; Mon, 14 Mar 2016 13:02:13 +0000 Received: from linode.thelabyrinth.net ([198.58.117.137] helo=mail.thelabyrinth.net) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1afS8P-000137-5i for pgsql-hackers@postgresql.org; Mon, 14 Mar 2016 13:02:12 +0000 Received: from [192.168.1.103] (wsip-184-178-50-4.dc.dc.cox.net [184.178.50.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteelepg) by mail.thelabyrinth.net (Postfix) with ESMTPSA id EBEC312D13; Mon, 14 Mar 2016 13:02:06 +0000 (UTC) Subject: Re: [WIP] Effective storage of duplicates in B-tree index. To: Anastasia Lubennikova , pgsql-hackers@postgresql.org References: <55E4051B.7020209@postgrespro.ru> <56AA2081.1080001@postgrespro.ru> <56AA3E06.8040006@postgrespro.ru> <56AB6D30.2040900@postgrespro.ru> <20160129184733.2ca9026a@fujitsu> <56AB9866.6050207@postgrespro.ru> <56C5FCE1.1090509@postgrespro.ru> <56C5FF80.5050905@postgrespro.ru> From: David Steele Message-ID: <56E6B64E.6000101@pgmasters.net> Date: Mon, 14 Mar 2016 09:02:06 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56C5FF80.5050905@postgrespro.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Hi Anastasia, On 2/18/16 12:29 PM, Anastasia Lubennikova wrote: > 18.02.2016 20:18, Anastasia Lubennikova: >> 04.02.2016 20:16, Peter Geoghegan: >>> On Fri, Jan 29, 2016 at 8:50 AM, Anastasia Lubennikova >>> wrote: >>>> I fixed it in the new version (attached). >> >> Thank you for the review. >> At last, there is a new patch version 3.0. After some refactoring it >> looks much better. >> I described all details of the compression in this document >> https://goo.gl/50O8Q0 (the same text without pictures is attached in >> btc_readme_1.0.txt). >> Consider it as a rough copy of readme. It contains some notes about >> tricky moments of implementation and questions about future work. >> Please don't hesitate to comment it. >> > Sorry, previous patch was dirty. Hotfix is attached. This looks like an extremely valuable optimization for btree indexes but unfortunately it is not getting a lot of attention. It still applies cleanly for anyone interested in reviewing. It's not clear to me that you answered all of Peter's questions in [1]. I understand that you've provided a README but it may not be clear if the answers are in there (and where). Also, at the end of the README it says: 13. Xlog. TODO. Does that mean the patch is not yet complete? Thanks, -- -David david@pgmasters.net [1] http://www.postgresql.org/message-id/CAM3SWZQ3_PLQCH4w7uQ8q_f2t4HEseKTr2n0rQ5pxA18OeRTJw@mail.gmail.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers