Subject: Re: Speed up Clog Access by increasing CLOG buffers
To: Amit Kapila <amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>
References: 
 <CAA4eK1J70Aj6Pvt31LYMD8ptMv7+9WFN0cQLq1LGhCYPFM9njw@mail.gmail.com>
 <CA+Tgmobf5PFpoi3w4zwf5DS0DzwYYpWzHDwwHmQw5Xto1dKyOg@mail.gmail.com>
 <CAA4eK1+dic2HZiqMf4o0O4acUP88R-5-A-9kXU9uz3COOW2WiA@mail.gmail.com>
 <CA+TgmobTdYgh24XNHMoGansYn=zCH5WzAg58jAeNA8WEVUbrbA@mail.gmail.com>
 <CAA4eK1L4iV-2qe7AyMVsb+nz7SiX8JvCO+CqhXwaiXgm3CaBUw@mail.gmail.com>
 <CAA4eK1KZ1HVOjy39i3FRS9MsbR6GgH8D7cqyoYJxyb2PJt05Qg@mail.gmail.com>
 <56E7032D.6060908@pgmasters.net>
 <CAA4eK1LGgOyn9OpiK8W3PfrXqfHsvTi0hy0y00bu50YfE_X+MA@mail.gmail.com>
 <20160322105221.GD3790@awork2.anarazel.de>
 <CAA4eK1+pWLPZGD6xYfJP=M6WHHzES-yyYSA4qpCA-jy0npKSUw@mail.gmail.com>
 <20160322125957.GH3790@awork2.anarazel.de>
 <CAA4eK1K9Z5L8rBu6nAk55oSTE4iC_aw=d+MyqpEy4UL6=aTG8w@mail.gmail.com>
CC: David Steele <david@pgmasters.net>, Robert Haas <robertmhaas@gmail.com>,
	Thom Brown <thom@linux.com>, Simon Riggs <simon@2ndquadrant.com>, Jesper
 Pedersen <jesper.pedersen@redhat.com>, pgsql-hackers
	<pgsql-hackers@postgresql.org>
From: Jim Nasby <Jim.Nasby@BlueTreble.com>
Message-ID: <56F20BAF.10803@BlueTreble.com>
Date: Tue, 22 Mar 2016 22:21:19 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: 
 <CAA4eK1K9Z5L8rBu6nAk55oSTE4iC_aw=d+MyqpEy4UL6=aTG8w@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2016 03:21:26.8066 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR11MB0675
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 3/22/16 9:36 AM, Amit Kapila wrote:
>  > > Note, that we are doing it only when a transaction has less than
> equal to
>  > > 64 sub transactions.
>  >
>  > So?
>  >
>
> They should fall on one page, unless they are heavily interleaved as
> pointed by you.  I think either subtransactions are present or not, this
> patch won't help for bigger transactions.

FWIW, the use case that comes to mind here is the "upsert" example in 
the docs. AFAIK that's going to create a subtransaction every time it's 
called, regardless if whether it performs actual DML. I've used that in 
places that would probably have moderately high concurrency, and I 
suspect I'm not alone in that.

That said, it wouldn't surprise me if plpgsql overhead swamps an effect 
this patch has, so perhaps it's a moot point.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers