Subject: Re: [PATCH] Alter or rename enum value
To: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>,
 pgsql-hackers@postgresql.org
References: 
 <CAO=2mx6uvgPaPDf-rHqG8=1MZnGyVDMQeh8zS4euRyyg4D35OQ@mail.gmail.com>
 <56E049CC.8010201@dunslane.net> <25605.1457539654@sss.pgh.pa.us>
 <56E05635.70908@dunslane.net> <28167.1457543612@sss.pgh.pa.us>
 <CAO=2mx4rQHRvifT2yUQ1rz90A=9CVz4_Z0Sx1wTgwgQRzAimpQ@mail.gmail.com>
 <CAO=2mx6rK_h4BC7y+3Nu-8fuZJXdFjd9FE_MZnzkH+vnMp0C-Q@mail.gmail.com>
 <d8ja8ln7nl0.fsf@dalvik.ping.uio.no> <d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
 Matthias Kurz <m.kurz@irregular.at>, Jim Nasby <Jim.Nasby@BlueTreble.com>,
 "David G. Johnston" <david.g.johnston@gmail.com>
From: Marko Tiikkaja <marko@joh.to>
Message-ID: <56F81BBF.7010905@joh.to>
Date: Sun, 27 Mar 2016 19:43:27 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2016-03-27 19:30, Dagfinn Ilmari Mannsåker wrote:
> ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>
>> I was bored and thought "how hard could it be?", and a few hours'
>> hacking later, I have something that seems to work.  It doesn't do IF
>> NOT EXISTS yet, and the error messaging could do with some improvement,
>> and there are no docs.  The patch is attached, as well as at
>> https://github.com/ilmari/postgres/commit/enum-alter-value
>
> Here's v3 of the patch of the patch, which I consider ready for proper
> review.

A couple of trivial comments below.

   +    <term><literal>ALTER VALUE [ IF EXISTST ] TO [ IF NOT EXISTS 
]</literal></term>

typo EXISTST

   +      If <literal>IF EXISTS</literal> or is <literal>IF NOT 
EXISTS</literal>
   +      is specified, it is not an error if the type doesn't contain 
the old

double is

   +      if the old value is not alreeady present or the new value is.

typo alreeady

   + * RenameEnumLabel
   + *		Add a new label to the enum set. By default it goes at

copypaste-o?

   +	if (!stmt->oldVal) {

not project curly brace style


.m


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers