Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAcpB-0009PM-1N for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Apr 2026 00:00:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wAcp9-002jw7-1l for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Apr 2026 00:00:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAcp9-002jvX-0n for pgsql-hackers@lists.postgresql.org; Thu, 09 Apr 2026 00:00:44 +0000 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wAcp7-000000004kh-1rwv for pgsql-hackers@postgresql.org; Thu, 09 Apr 2026 00:00:43 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8EFCB14001B5; Wed, 8 Apr 2026 20:00:40 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Wed, 08 Apr 2026 20:00:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1775692840; x=1775779240; bh=MBZVhqTx/U4yrPqbgMD4zEP/IzaY3hKi5ghW3+S9Fcc=; b= DP6Ft1E4k98b0Kt1eqbRt0bpJw9I4pp7ftAuNnlHVrj//20qWqzxiT+0tHnYOMQX jMq4JPXl8BIioDB82Mi0RHDjXn10lAbkEDEJv/ad6chR2uMzMNRp7NkT9WCasc1t HKv53JXX2BjrdPHNsHT6KD2hMVL5P68/NwM+UuLmwv2ep3VeX7htZinTFlE656c5 mVwPWtXZsv5LtICGrlfPzc5Q1CEF66XsQQuHblsKmeYjrYvTn+tgBqGKN2Mush8E eh3KGWZwpUUGQnnomPBXviy3BqQbgMzm0V3+EAPp6pptX54ZqGYnx4gXLxGHeJ9F 7ie/e+fJxvwejVdd4IodwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1775692840; x=1775779240; bh=M BZVhqTx/U4yrPqbgMD4zEP/IzaY3hKi5ghW3+S9Fcc=; b=QCb93nwBH+PmLkrFG +XpHyvf0tvfAtmBlPzCL9I1kjZFu+y/5Z4QQ1mW9mDNT45AtbbA512X0wBozkQ8I sV2UDolriQfAK47tFtvVEH72z7Hhwnc3KYdiodl7gaLLNFJ60NJB1pcgp2TpVTwa YMGLVqKtH8rdCL2nrmrGNrno3PfkGG/3yBOxfEboL/uK/suNs+5F+9XeJg7Y8ylT Eo1RAfD4H5Lrvb4cO8biwfhssWpRKM5WwbpkAFf6gCm7pT2U2JS/ZpjvBfkTbsJI Fuzd+8VvHjfy/SoZCCULRxwBjB5N866uhqw8xrcqvhkAOeO6oyBTa9BZNmeenFT4 b7TTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvgeelhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvghtvghrucfg ihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqnecugg ftrfgrthhtvghrnhepheeivdfhuefhueeggfefheegjedtveeuhfethfeufedvudfgtdeu hefgfeduhfffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhnsggprhgtphhtthhopedv pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrnhgurhgvshesrghnrghrrgiivg hlrdguvgdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehpohhsthhgrhgvshhq lhdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Apr 2026 20:00:38 -0400 (EDT) Message-ID: <56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org> Date: Thu, 9 Apr 2026 02:00:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: s/pg_attribute_always_inline/pg_always_inline/? To: Andres Freund , pgsql-hackers@postgresql.org References: Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 08.04.26 23:09, Andres Freund wrote: > Hi, > > When reviewing the index prefetching patch I got a bit dismayed at how long > pg_attribute_always_inline is due to the way it triggers pgindent to format > stuff. > > I propose that we remove the _attribute_ part of the name. > > Given that it is implemented for compilers that don't use the > __attribute__((always_inline)) spelling, so the shorter name seems better > anyway. Yes, and the existing name is also kind of wrong even on GCC because the macro does not expand to only an attribute but also includes the "inline".