From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>,
        Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade test writes to source directory
In-reply-to: <e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com>
References: <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
 <Yo/mWGJjCHOH3eB1@paquier.xyz> <20220526205218.GC19626@telsasoft.com>
 <Yo/5MlXbwY4UhMnm@paquier.xyz> <2464542.1653603596@sss.pgh.pa.us>
 <YpAMBqPrusng47e0@paquier.xyz> <2480063.1653609068@sss.pgh.pa.us>
 <YpAV1y8CUXGGkPJQ@paquier.xyz>
 <20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
 <3131727.1653768841@sss.pgh.pa.us> <YpXA7XHZtunxalTr@paquier.xyz>
 <e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@enterprisedb.com>
	message dated "Wed, 01 Jun 2022 16:11:16 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <571132.1654095328.1@sss.pgh.pa.us>
Date: Wed, 01 Jun 2022 10:55:28 -0400
Message-ID: <571133.1654095328@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/571133.1654095328%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 31.05.22 09:17, Michael Paquier wrote:
>> Well, here is a formal patch set, then.  Please feel free to comment.
>> 
>> FWIW, I am on the fence with dropping TESTDIR, as it could be used by
>> out-of-core test code as well.  If there are doubts about
>> back-patching the first part, doing that only on HEAD would be fine to
>> fix the problem of this thread.

> I don't understand the point of this first patch at all.  Why define 
> TESTOUTDIR as a separate variable if it's always TESTDIR + tmp_check? 
> Why define TESTOUTDIR in pg_regress invocations, if nothing uses it?  If 
> you want it as a separate variable, it could be defined in some Per 
> utility module, but I don't see why it needs to be in Makefile.global. 
> What is the problem that this is trying to solve?

Yeah, after looking this over it seems like we could drop 0001 and
just change 0002 to chdir into TESTDIR then into tmp_check.  I'm not
sure I see the point of inventing a new global variable either,
and I'm definitely not happy with the proposed changes to 
010_tab_completion.pl.  My recollection is that those tests
were intentionally written to test tab completion involving a
directory name, but this change just loses that aspect entirely.

			regards, tom lane