From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Giving more detail in pg_upgrade errormessage
In-reply-to: <E0D5EA16-A085-4753-8DDC-C7055048B439@yesql.se>
References: <E0D5EA16-A085-4753-8DDC-C7055048B439@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Tue, 18 Jul 2023 16:59:32 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <57270.1689696260.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 18 Jul 2023 12:04:20 -0400
Message-ID: <57271.1689696260@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/57271.1689696260%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> Looking at the upgrade question in [0] made me realize that we discard
> potentially useful information for troubleshooting.  When we check if th=
e
> cluster is properly shut down we might as well include the status from
> pg_controldata in the errormessage as per the trivial (but yet untested)
> proposed diff.

> Is there a reason not to be verbose here as users might copy/paste this =
output
> when asking for help?

Agreed, but I think you need to chomp the string's trailing newline,
or it'll look ugly.  You might as well do that further up and remove
the newlines from the comparison strings, too.

			regards, tom lane