Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aymfe-000274-AY for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2016 20:48:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aymfd-0001O4-QP for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2016 20:48:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aymfd-0001Nx-8i for pgsql-hackers@postgresql.org; Fri, 06 May 2016 20:48:21 +0000 Received: from lists.commandprompt.com ([69.168.55.30]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aymfU-0003J2-Ps for pgsql-hackers@postgresql.org; Fri, 06 May 2016 20:48:20 +0000 Received: from [192.168.1.60] (spinlock.commandprompt.com [69.168.55.30]) by lists.commandprompt.com (Postfix) with ESMTPA id 00FD43A9; Fri, 6 May 2016 13:48:09 -0700 (PDT) Received: from c-73-225-27-179.hsd1.wa.comcast.net ([73.225.27.179] helo=[192.168.1.60]) by assp.commandprompt.com with SMTPSA(TLSv1_2 ECDHE-RSA-AES128-GCM-SHA256) (2.4.5); 6 May 2016 13:48:09 -0700 Subject: Re: Reviewing freeze map code To: Robert Haas , Andres Freund References: <20160502214818.psk3lmgyihk6gr3k@alap3.anarazel.de> <20160505000840.epatoq6d2e556446@alap3.anarazel.de> Cc: Masahiko Sawada , "pgsql-hackers@postgresql.org" From: "Joshua D. Drake" Organization: Command Prompt, Inc. Message-ID: <572D0309.4090402@commandprompt.com> Date: Fri, 6 May 2016 13:48:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Assp-Version: 2.4.5(15162) on assp.commandprompt.com X-Assp-ID: assp.commandprompt.com m1-67689-12349 X-Assp-Session: D992A08 (mail 1) X-Assp-Envelope-From: jd@commandprompt.com X-Assp-Intended-For: pgsql-hackers@postgresql.org X-Assp-Intended-For: sawada.mshk@gmail.com X-Assp-Intended-For: andres@anarazel.de X-Assp-Intended-For: robertmhaas@gmail.com X-Assp-Original-Subject: Re: [HACKERS] Reviewing freeze map code X-Assp-Client-SSL: yes X-Pg-Spam-Score: -4.0 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/06/2016 01:40 PM, Robert Haas wrote: > On Wed, May 4, 2016 at 8:08 PM, Andres Freund wrote: >> On 2016-05-02 14:48:18 -0700, Andres Freund wrote: >>> 77a1d1e Department of second thoughts: remove PD_ALL_FROZEN. >> >> Nothing to say here. >> >>> fd31cd2 Don't vacuum all-frozen pages. >> >> Hm. I do wonder if it's going to bite us that we don't have a way to >> actually force vacuuming of the whole table (besides manually rm'ing the >> VM). I've more than once seen VACUUM used to try to do some integrity >> checking of the database. How are we actually going to test that the >> feature works correctly? They'd have to write checks ontop of >> pg_visibility to see whether things are borked. > > Let's add VACUUM (FORCE) or something like that. This is actually inverted. Vacuum by default should vacuum the entire relation, however if we are going to keep the existing behavior of this patch, VACUUM (FROZEN) seems to be better than (FORCE)? Sincerely, JD -- Command Prompt, Inc. http://the.postgres.company/ +1-503-667-4564 PostgreSQL Centered full stack support, consulting and development. Everyone appreciates your honesty, until you are honest with them. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers