Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aymlP-0002R8-ES for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2016 20:54:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aymlO-0006Yb-PN for pgsql-hackers@arkaria.postgresql.org; Fri, 06 May 2016 20:54:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aymlO-0006YV-9Q for pgsql-hackers@postgresql.org; Fri, 06 May 2016 20:54:18 +0000 Received: from lists.commandprompt.com ([69.168.55.30]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aymlH-0003E9-5I for pgsql-hackers@postgresql.org; Fri, 06 May 2016 20:54:17 +0000 Received: from [192.168.1.60] (spinlock.commandprompt.com [69.168.55.30]) by lists.commandprompt.com (Postfix) with ESMTPA id 963C13A9; Fri, 6 May 2016 13:54:09 -0700 (PDT) Received: from c-73-225-27-179.hsd1.wa.comcast.net ([73.225.27.179] helo=[192.168.1.60]) by assp.commandprompt.com with SMTPSA(TLSv1_2 ECDHE-RSA-AES128-GCM-SHA256) (2.4.5); 6 May 2016 13:54:09 -0700 Subject: Re: Reviewing freeze map code To: Andres Freund References: <20160502214818.psk3lmgyihk6gr3k@alap3.anarazel.de> <20160505000840.epatoq6d2e556446@alap3.anarazel.de> <572D0309.4090402@commandprompt.com> <20160506205012.ipuhvctss2ozzs6m@alap3.anarazel.de> Cc: Robert Haas , Masahiko Sawada , "pgsql-hackers@postgresql.org" From: "Joshua D. Drake" Organization: Command Prompt, Inc. Message-ID: <572D0471.3040009@commandprompt.com> Date: Fri, 6 May 2016 13:54:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160506205012.ipuhvctss2ozzs6m@alap3.anarazel.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Assp-Version: 2.4.5(15162) on assp.commandprompt.com X-Assp-ID: assp.commandprompt.com m1-68049-04124 X-Assp-Session: 7FC1037AE528 (mail 1) X-Assp-Envelope-From: jd@commandprompt.com X-Assp-Intended-For: pgsql-hackers@postgresql.org X-Assp-Intended-For: sawada.mshk@gmail.com X-Assp-Intended-For: robertmhaas@gmail.com X-Assp-Intended-For: andres@anarazel.de X-Assp-Original-Subject: Re: [HACKERS] Reviewing freeze map code X-Assp-Client-SSL: yes X-Pg-Spam-Score: -4.0 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/06/2016 01:50 PM, Andres Freund wrote: >>> Let's add VACUUM (FORCE) or something like that. > > Yes, that makes sense. > > >> This is actually inverted. Vacuum by default should vacuum the entire >> relation > > What? Why on earth would that be a good idea? Not to speak of hte fact > that that's not been the case since ~8.4? Sorry, I just meant the default behavior shouldn't change but I do agree that we need the ability to keep the same behavior. >> ,however if we are going to keep the existing behavior of this >> patch, VACUUM (FROZEN) seems to be better than (FORCE)? > > There already is FREEZE - meaning something different - so I doubt it. Yeah I thought about that, it is the word "FORCE" that bothers me. When you use FORCE there is an assumption that no matter what, it plows through (think rm -f). So if we don't use FROZEN, that's cool but FORCE doesn't work either. Sincerely, JD -- Command Prompt, Inc. http://the.postgres.company/ +1-503-667-4564 PostgreSQL Centered full stack support, consulting and development. Everyone appreciates your honesty, until you are honest with them. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers